Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funder Dropdown Options #1030

Closed
vs77bb opened this issue Apr 30, 2018 · 8 comments
Closed

Funder Dropdown Options #1030

vs77bb opened this issue Apr 30, 2018 · 8 comments

Comments

@vs77bb
Copy link
Contributor

vs77bb commented Apr 30, 2018

User Story

As a Funder, I want to know the top funding options (ETH, DAI) so that I can fund my bounties in the currency which is most easily consumed by the developer community.

Description

Type: Feature

Summary: Make ETH and DAI the top two currencies on the Funder drop-down, and then roll alphabetically from there with all other accepted ERC-20 tokens.

Actual behavior

Currently, fully alphabetical order.

Expected behavior

ETH, DAI, then alphabetical order.

@vs77bb vs77bb changed the title Oasis Direct Funder Dropdown Options Apr 30, 2018
@thelostone-mc
Copy link
Member

We could default the value to ETH so that that gets populated as the default value !

I agree that the ETH and DAI are the most popular -> but is it okay to mix up the order ?
(Our dropdown have a built in search filter so prevents them from aimlessly scrolling )

That said if users feels that they'd like to see the popular tokens on the top of the list -> we could do that ^_^

@owocki
Copy link
Contributor

owocki commented May 8, 2018

We could default the value to ETH so that that gets populated as the default value !

this happens already :)

I agree that the ETH and DAI are the most popular -> but is it okay to mix up the order ?

we could make it so that they appear twice!

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.015 ETH (11.12 USD @ $741.02/ETH) attached to it.

@cupOJoseph
Copy link
Contributor

cupOJoseph commented May 9, 2018

@gitcoinbot
Copy link
Member

gitcoinbot commented May 9, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

  1. @bakaoh

has committed to working on this project to be completed 3 weeks from now.

@owocki, please see the below comments on the approach / questions:

bakaoh pushed a commit to bakaoh/web that referenced this issue May 9, 2018
@bakaoh
Copy link
Contributor

bakaoh commented May 9, 2018

@jschiarizzi --- thanks for your help ^^

@vs77bb -- i've done as the request and make a PR,
i guess if the dropdown only show tokens user owned (like etherscan) that should be better, but it requires an api so we may save it for later

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.015 ETH (10.9 USD @ $726.6/ETH) has been submitted by:

  1. @bakaoh

@owocki please take a look at the submitted work:


mbeacom pushed a commit that referenced this issue May 17, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.015 ETH (10.59 USD @ $706.21/ETH) attached to this issue has been approved & issued to @bakaoh.

@gitcoinco gitcoinco deleted a comment May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants