Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typography cleanup after PR 116 #151

Closed
owocki opened this issue Dec 20, 2017 · 5 comments
Closed

typography cleanup after PR 116 #151

owocki opened this issue Dec 20, 2017 · 5 comments
Labels
easy-pickings This is an easy issue for the community.

Comments

@owocki
Copy link
Contributor

owocki commented Dec 20, 2017

from #116

1

https://gitcoin.co/tip

for consistency.. might be worth doing the same thing for the tips flow...

2

http://bits.owocki.com/3N2V1400343O/Screen%20Shot%202017-12-20%20at%203.49.00%20AM.png

one other small cleanup thing: we should probably have consistent capitalization on the bounty detail page
@owocki owocki changed the title typography cleanup typography cleanup after PR 116 Dec 20, 2017
@owocki owocki added the easy-pickings This is an easy issue for the community. label Dec 20, 2017
@bumi
Copy link
Contributor

bumi commented Dec 20, 2017

1

The /tip application is yge in the code? (https://github.com/gitcoinco/web/tree/7680fc5425ae3524981b4ca912640d7af13c705c/app/dashboard/templates/yge) - correct? sorry, I am just figuring out what goes where :)
there was a global style, I will update that and make a PR.

2

what is inconsistent? (I'm blind)

@owocki
Copy link
Contributor Author

owocki commented Dec 20, 2017

  1. yep. its a fork of https://github.com/youvegoteth/youvegoteth.github.io/
  2. status: activated is lower case vs Experience Level: Intermediate (among maybe other things too)

@bumi
Copy link
Contributor

bumi commented Dec 21, 2017

ok, thanks. will check it out during the weekend.

bumi added a commit to bumi/web that referenced this issue Dec 30, 2017
@bumi
Remove all-caps default in /tip (yge)
93bbbe7 
ref: gitcoinco#151
@bumi bumi mentioned this issue Dec 30, 2017
Merged
1 task
ethikz pushed a commit to ethikz/web that referenced this issue Jan 24, 2018
@bumi
Remove all-caps default in /tip (yge)
ec3c369 
ref: gitcoinco#151
@D3RPZ1LLA
Copy link

@owocki Looks like something has been merged.
Is this issue resolved? Please clarify

@owocki
Copy link
Contributor Author

owocki commented Jan 26, 2018

yes it has.. thanks for the bump

@owocki owocki closed this as completed Jan 26, 2018
owocki pushed a commit that referenced this issue Apr 30, 2021
@scco
Merge pull request #151 from nopslip/QL2_richard_frontend
74ab77e 
added a network indicator to navigation + lazy loading images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy-pickings This is an easy issue for the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bumi @owocki @D3RPZ1LLA