Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stale bounties filter #197

Closed
owocki opened this issue Dec 31, 2017 · 19 comments
Closed

stale bounties filter #197

owocki opened this issue Dec 31, 2017 · 19 comments
Assignees
@owocki
Labels
help wanted

Comments

@owocki
Copy link
Contributor

owocki commented Dec 31, 2017 •
edited
Loading

put a radio button on the gitcoin.co/explorer sidebar that filters out any bounties that have had action on them in the last X days. these bounties are stale in that whomever has claimed them is not doing active work

X = 5 for intiial MVP
@owocki
Copy link
Contributor Author

owocki commented Jan 12, 2018

cc @vs77bb in case this would help you in your weekly pruning of bounties in any way...

@owocki owocki changed the title idea: stale bounties filter stale bounties filter Mar 19, 2018
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.1 ETH (54.11 USD @ $541.12/ETH) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $3038.65 more Funded OSS Work Available at: https://gitcoin.co/explorer

@gitcoinbot
Copy link
Member

gitcoinbot commented Mar 20, 2018 •
edited
Loading

Issue Status: 1. Open 2. Cancelled

Work has been started.

  1. @davidbanu

has committed to working on this project to be completed 2 weeks, 6 days ago.

@vs77bb
Copy link
Contributor

vs77bb commented Mar 20, 2018

Hi @leonj3813 are you working this one right now? I think this is a great task that can help us improve the product experience a ton 🙂

@leonj3813
Copy link

Hey @vs77bb I'm working on adding this. I'm setting up my local environment and then I'll add to the refreshBounties uri to get the new information from the HTTPS API.

@leonj3813
Copy link

What is the best way to define an action on a bounty? I can filter x days from the time in the "modified_on" field easy enough.

@owocki
Copy link
Contributor Author

owocki commented Mar 21, 2018 •
edited
Loading

I can filter x days from the time in the "modified_on" field easy enough.

this works! i may also add a last_commented_date to the model in the future too

@leonj3813
Copy link

@owocki Yeah I tested this last night and it looks like the modified_on field is getting updated every 15 minutes on the live api https://gitcoin.co/api/v0.1/bounties/.
Maybe a cron job is running that runs refresh_bounties.py every 15 minutes to update the github comment count, then this saves the model which updates the modified_on field, I don't know for sure.

If this is the case then I guess a last_commented_date field would have to be added to the model and this could be updated in refresh_bounties.py. This field would probably help with #567 also.

@vs77bb vs77bb mentioned this issue Mar 22, 2018
Closed
owocki added a commit that referenced this issue Mar 24, 2018
@owocki
fix for #197 (comment)
ed08a04
@owocki
Copy link
Contributor Author

owocki commented Mar 24, 2018

@leonj3813 ed08a04 should give u what u need

leonj3813 added a commit to leonj3813/web that referenced this issue Mar 26, 2018
@leonj3813
- Added last_comment_date model field to api.
6017971 
- Put a radio button on the search sidebar that filters out bounties
  that have been commented on in the last x days based on the last_comment_date
  model field. X = 5, 10 and 30.
- Added css class to sidebar_search.css that allows labels under
  form__radio to wrap. Needed for proper formatting of new radio button
  labels.

Refs: gitcoinco#197
@leonj3813 leonj3813 mentioned this issue Mar 26, 2018
Closed
3 tasks
leonj3813 added a commit to leonj3813/web that referenced this issue Mar 30, 2018
@leonj3813
- Added last_comment_date model field to api.
ec7d42a 
- Put a radio button on the search sidebar that filters out bounties
  that have been commented on in the last x days based on the last_comment_date
  model field. X = 5, 10 and 30.
- Added css class to sidebar_search.css that allows labels under
  form__radio to wrap. Needed for proper formatting of new radio button
  labels.

Refs: gitcoinco#197
leonj3813 added a commit to leonj3813/web that referenced this issue Mar 30, 2018
@leonj3813
- Added last_comment_date model field to api.
64b9624 
- Put a radio button on the search sidebar that filters out bounties
  that have been commented on in the last x days based on the last_comment_date
  model field. X = 5, 10 and 30.
- Added css class to sidebar_search.css that allows labels under
  form__radio to wrap. Needed for proper formatting of new radio button
  labels.

Refs: gitcoinco#197
leonj3813 added a commit to leonj3813/web that referenced this issue Mar 30, 2018
@leonj3813
- Added last_comment_date model field to api.
1b737ca 
- Put a radio button on the search sidebar that filters out bounties
  that have been commented on in the last x days based on the last_comment_date
  model field. X = 5, 10 and 30.
- Added css class to sidebar_search.css that allows labels under
  form__radio to wrap. Needed for proper formatting of new radio button
  labels.

Refs: gitcoinco#197
@vs77bb
Copy link
Contributor

vs77bb commented Apr 8, 2018

@owocki Is this one with you for review?

@owocki
Copy link
Contributor Author

owocki commented Apr 9, 2018

from the pr we are waiting on the turnaround of a few comments from @leonj3813 -- then we can pay it out

@gitcoinco gitcoinco deleted a comment from gitcoinbot Apr 28, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Apr 28, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Apr 28, 2018
@vs77bb
Copy link
Contributor

vs77bb commented Apr 28, 2018

@leonj3813 Any update here to get it across the finish line? Hope you are doing well!

@gitcoinbot
Copy link
Member

@davidbanu are you still working on this issue?

  • warning 1 (3 days)
  • warning 2 (6 days)
  • auto removal (10 days)

@gitcoinbot
Copy link
Member

@davidbanu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • auto removal (6 days)

1 similar comment
@gitcoinbot
Copy link
Member

@davidbanu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • auto removal (6 days)

@gitcoinbot
Copy link
Member

@davidbanu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • auto removal (6 days)

@vs77bb
Copy link
Contributor

vs77bb commented May 8, 2018

@owocki @mbeacom I think we don't need this filter anymore given our new plan for managing stale bounties elsewhere. @owocki you can probably claw back funds here

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled

The funding of 0.1 ETH (74.1 USD @ $741.02/ETH) attached to this issue has been cancelled by the bounty submitter

@thelostone-mc
Copy link
Member

I think we don't need this filter anymore given our new plan for managing stale bounties elsewhere

Closing this!

@gitcoinco gitcoinco deleted a comment May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owocki owocki

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@PixelantDesign @owocki @leonj3813 @thelostone-mc @vs77bb @gitcoinbot