-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list of erc20 coins should be more elegant #3
Comments
This issue now has a funding of 0.02 ETH attached to it. Learn more at: https://gitcoin.co/bounty/details?url=https://github.com/gitcoinco/web/issues/3 |
Here's the prototype UI that replace the dropdown
https://jsfiddle.net/gasolin/n4s1qwhu/ @owocki how do you think? |
first, hi 👋 -- thanks for taking an interest in this bounty! i think that it works at a small scale, and i appreciate the prototype, but with i'm worried aobut what it'd look like with 100+ supported tokens ( see https://gitcoin.co/static/v2/js/tokens.js to see all of the supported tokens ). i wonder if an auto complete interface or a searchable "" box might be better patterns to adopt... @mbeylin what do you think? |
also, sorry -- i guess i didnt make the 100+ thing clear in the original requirements list. i guess thats why its good that there's 'milestones' in here. |
It seems like this could easily be accomplished with the |
i like the UI of react-select but im not crazy about adding all of these dependancies to the page http://bits.owocki.com/1l1g002M3b0T/Screen%20Shot%202017-09-30%20at%209.58.08%20AM.png |
Ooh so you still want a dropdown menu but with search function:sweat_smile: If we want jquery only, |
just generally want a dropdown that scales for large lists... but yeah, a dropdown with search sounds great :)
that looks good to me. want to submit a PR and a claim for this bounty? i'm happy to send a Gitcoin Tip in addition to the bounty since the requirements / investigation took a little longer than expected. |
add dropdown menu search via select2, fix #3
The funding of 0.02 ETH attached to this issue has been approved & issue.d Learn more at: https://gitcoin.co/funding/details?url=https://github.com/gitcoinco/web/issues/3 |
⚡️ A tip worth 0.01 ETH has been granted to @gasolin for this issue from @owocki. ⚡️ Nice work @gasolin, check your email for further instructions. | Send a Tip |
# This is the 1st commit message: Lab Page init # This is the commit message gitcoinco#2: Lab Hero Added # This is the commit message gitcoinco#3: Fixed migrations and StyleLint
* Updating read replica list to include #3 * Adding read_replica_3 to settings
* Updating read replica list to include #3 * Adding read_replica_3 to settings
http://bits.owocki.com/2n1B3R0U422W/Image%202017-09-25%20at%205.09.12%20AM.png
requirements:
The text was updated successfully, but these errors were encountered: