Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list of erc20 coins should be more elegant #3

Closed
owocki opened this issue Sep 25, 2017 · 10 comments
Closed

list of erc20 coins should be more elegant #3

owocki opened this issue Sep 25, 2017 · 10 comments

Comments

@owocki
Copy link
Contributor

owocki commented Sep 25, 2017

http://bits.owocki.com/2n1B3R0U422W/Image%202017-09-25%20at%205.09.12%20AM.png

requirements:

  • design a method for working with the erc20 coins that is more elegant than this
  • if a list is presented, they must be in alphabetical order
  • it'd be greaet to detect which coins a user actually has
  • mileestone 1: propose design. milestone 2: submit PR
@gitcoinbot
Copy link
Member

gitcoinbot commented Sep 25, 2017

This issue now has a funding of 0.02 ETH attached to it.

Learn more at: https://gitcoin.co/bounty/details?url=https://github.com/gitcoinco/web/issues/3

@gasolin
Copy link
Contributor

gasolin commented Sep 30, 2017

Here's the prototype UI that replace the dropdown

  • when user click the select another Token link, show a list of tokens
  • user click one of token, the list of tokens is gone and show the selected token and the select another Token link

https://jsfiddle.net/gasolin/n4s1qwhu/

@owocki how do you think?

@owocki
Copy link
Contributor Author

owocki commented Sep 30, 2017

first, hi 👋 -- thanks for taking an interest in this bounty!

i think that it works at a small scale, and i appreciate the prototype, but with i'm worried aobut what it'd look like with 100+ supported tokens ( see https://gitcoin.co/static/v2/js/tokens.js to see all of the supported tokens ). i wonder if an auto complete interface or a searchable "" box might be better patterns to adopt... @mbeylin what do you think?

@owocki
Copy link
Contributor Author

owocki commented Sep 30, 2017

also, sorry -- i guess i didnt make the 100+ thing clear in the original requirements list. i guess thats why its good that there's 'milestones' in here.

@mbeylin
Copy link

mbeylin commented Sep 30, 2017

It seems like this could easily be accomplished with the react-select module, or a ui element which replicates it. The basic idea being that the dropdown has a maximum length, and searching with a query helps to refine the list.

http://jedwatson.github.io/react-select/

@owocki
Copy link
Contributor Author

owocki commented Sep 30, 2017

i like the UI of react-select but im not crazy about adding all of these dependancies to the page http://bits.owocki.com/1l1g002M3b0T/Screen%20Shot%202017-09-30%20at%209.58.08%20AM.png

@gasolin
Copy link
Contributor

gasolin commented Oct 1, 2017

Ooh so you still want a dropdown menu but with search function:sweat_smile: If we want jquery only, select2 seems a good fit https://select2.org/getting-started/basic-usage

@owocki
Copy link
Contributor Author

owocki commented Oct 1, 2017

Ooh so you still want a dropdown menu but with search function:sweat_smile:

just generally want a dropdown that scales for large lists... but yeah, a dropdown with search sounds great :)

If we want jquery only, select2 seems a good fit https://select2.org/getting-started/basic-usage

that looks good to me. want to submit a PR and a claim for this bounty? i'm happy to send a Gitcoin Tip in addition to the bounty since the requirements / investigation took a little longer than expected.

@owocki owocki closed this as completed in f430e0b Oct 2, 2017
owocki added a commit that referenced this issue Oct 2, 2017
add dropdown menu search via select2, fix #3
@gitcoinbot
Copy link
Member

gitcoinbot commented Oct 2, 2017

The funding of 0.02 ETH attached to this issue has been approved & issue.d

Learn more at: https://gitcoin.co/funding/details?url=https://github.com/gitcoinco/web/issues/3

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.01 ETH has been granted to @gasolin for this issue from @owocki. ⚡️

Nice work @gasolin, check your email for further instructions. | Send a Tip

owocki pushed a commit that referenced this issue Oct 5, 2018
captnseagraves added a commit that referenced this issue Nov 16, 2018
aashutoshrathi added a commit to aashutoshrathi/web that referenced this issue Dec 6, 2018
# This is the 1st commit message:

Lab Page init

# This is the commit message gitcoinco#2:

Lab Hero Added

# This is the commit message gitcoinco#3:

Fixed migrations and StyleLint
zlsgh added a commit that referenced this issue Sep 8, 2021
thelostone-mc pushed a commit that referenced this issue Sep 15, 2021
* Updating read replica list to include #3

* Adding read_replica_3 to settings
jeremyschuurmans pushed a commit that referenced this issue Sep 22, 2021
* Updating read replica list to include #3

* Adding read_replica_3 to settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants