Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitcoinbot tune up #596

Closed
owocki opened this issue Mar 12, 2018 · 11 comments
Closed

gitcoinbot tune up #596

owocki opened this issue Mar 12, 2018 · 11 comments
Labels
enhancement This is a feature to be enhanced or improved.

Comments

@owocki
Copy link
Contributor

owocki commented Mar 12, 2018

please read this before responding to this issue => https://github.com/gitcoinco/web/tree/master/app/gitcoinbot

  • add start work functionality
  • claim - rename to submit work
  • claim [if there is no active bounty] tell the user there is no active bounty and instruct them where to start a bounty
  • claim -- use the new gitcoin url format (https://gitcoin.co/issue/org/repo/num instead of https://gitcoin.co/funding/details/?url=url)
  • @gitcoinbot bounty 0 ETH -- better bounds checking -- this should not work. check for negatives.
  • expand gitcoinbot to work with any of the tokens in tokens.py (not just ETH)
  • add a GitcoinBotResponses model to the gitcoinbot/models.py file which has a request and response varchar(500) field. program the bot such that if a user queries gitcoinbot with @gitcoinbot <request> (case insensitive) it will respond with @user_who_queried_me <response>
@mbeacom mbeacom added bot enhancement This is a feature to be enhanced or improved. labels Mar 12, 2018
@owocki
Copy link
Contributor Author

owocki commented Mar 12, 2018

[if gitcoinbot is not installed as an app] make it so that gitcoinbot responds and tells the user to install the app. to make this work, the plan was to poll gitcoinbot for notifications and respond to them

ok finished up the first requiremnt http://bits.owocki.com/2r1n3c0V2G0Z/Screen%20Shot%202018-03-12%20at%2011.38.59%20AM.png

22f25a0

removing this from the list now

owocki added a commit that referenced this issue Mar 12, 2018
…ot responds and tells the user to install the app. to make this work, the plan was to poll gitcoinbot for notifications and respond to them

#596
@owocki owocki changed the title gitcoinbot v2 gitcoinbot tune up Mar 12, 2018
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.1 ETH (69.79 USD @ $697.88/ETH) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $3957.31 more Funded OSS Work Available at: https://gitcoin.co/explorer

@gitcoinbot
Copy link
Member

gitcoinbot commented Mar 13, 2018

Work has been started on the 0.1 ETH (42.23 USD @ $422.33/ETH) funding by:

  1. @zoek1

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@zoek1
Copy link
Contributor

zoek1 commented Mar 13, 2018

@owocki any particular text message for start work functionality?

@owocki
Copy link
Contributor Author

owocki commented Mar 13, 2018

@zoek1 just stub in copy that you think makes sense and ill update it before deploying to prod if i dislike it :)

@zoek1
Copy link
Contributor

zoek1 commented Mar 14, 2018

@owocki, this way to handle bounds it's ok for you? Handle bounds

Also, the start work command should call the new_interest function in dashboard/views or show the link to call such method?

Last, what criteria will be used to store the requests onto GitcoinBotResponses? This feature is for cache all requests ?

@owocki
Copy link
Contributor Author

owocki commented Mar 14, 2018

@owocki, this way to handle bounds it's ok for you? Handle bounds

cool! very elegant!

Also, the start work command should call the new_interest function in dashboard/views or show the link to call such method?

seems more elegant to pull up the bounty detail page and automatically click the link... but i could also see 'highlight'ing the link being okay too

Last, what criteria will be used to store the requests onto GitcoinBotResponses? This feature is for cache all requests ?

i'm not sure i follow the question... no this feature is not meant to cache all requests. i intended it such that an admin could build functionality into the bot over time without changing the code.

for example, i as an admin could enter a GitcoinBotResponses a row where the request == what is the airspeed velocity of an unladen swallow and the response == “What do you mean? African or European swallow?” and hereafter the gitcoinbot would responsd to any request that matches the request with that response.

@zoek1 zoek1 mentioned this issue Mar 18, 2018
7 tasks
@zoek1
Copy link
Contributor

zoek1 commented Mar 18, 2018

Hi @owocki can you review the PR #641, please. Sorry for delay, but i had exams the last week.

@owocki
Copy link
Contributor Author

owocki commented Mar 19, 2018

thanks for the bump. just commented!

@gitcoinbot
Copy link
Member

Work for 0.1 ETH (52.01 USD @ $520.1/ETH) has been submitted by:

  1. @zoek1

Submitters, please leave a comment to let the funder (@owocki) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

@gitcoinbot
Copy link
Member

The funding of 0.1 ETH (46.39 USD @ $463.89/ETH) attached to this issue has been approved & issued to @zoek1.

@gitcoinco gitcoinco deleted a comment May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature to be enhanced or improved.
Projects
None yet
Development

No branches or pull requests

5 participants