Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone issues with opened date #876

Closed
owocki opened this issue Apr 12, 2018 · 7 comments
Closed

timezone issues with opened date #876

owocki opened this issue Apr 12, 2018 · 7 comments
Assignees

Comments

@owocki
Copy link
Contributor

owocki commented Apr 12, 2018

http://bits.owocki.com/2I460x3e1T0Z/Screen%20Shot%202018-04-12%20at%202.30.06%20PM.png

https://gitcoin.co/issue/gitcoinco/web/865

This bounty was really opened 3 hours ago but the 'opened' date says 10 hours ago

@kziemianek
Copy link
Contributor

kziemianek commented Apr 18, 2018

@owocki, @mbeacom seems like switching to UTC timezone solves problem. I agree that dates should be stored in UTC format.

TIME_ZONE = env.str('TIME_ZONE', default='UTC')

What do You think about changing timezone ? Seems to be fundamental change and i'm not aware of all django internals and problems it might rise with current implementation.

@mkosowsk
Copy link

Time zone funkiness is why I changed my life to be running on UTC, just one less thing to worry about :)

  • Mitch Kosowski, Posted at 11:02 AM UTC

@mbeacom
Copy link
Contributor

mbeacom commented Apr 18, 2018

@kziemianek Agreed.

We should ensure we're storing UTC and implement: https://docs.djangoproject.com/en/2.0/topics/i18n/timezones/

@owocki
Copy link
Contributor Author

owocki commented Apr 18, 2018

@mbeacom what do you think about changing settings.py:163 to set the default as UTC as a means of solving the original issue?

@owocki
Copy link
Contributor Author

owocki commented Apr 18, 2018

fixed in #919 (comment)

@owocki
Copy link
Contributor Author

owocki commented Apr 18, 2018

thanks @kziemianek

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.025 ETH (12.85 USD @ $513.94/ETH) has been granted to @kziemianek for this issue from Kevin. ⚡️

The sender had the following public comments:

Thanks for the tip about the django setting

Nice work @kziemianek! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants