Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test button to test slack integration #1070

Merged
merged 1 commit into from
May 5, 2018

Conversation

darkdarkdragon
Copy link
Contributor

Description

Add test button to test slack integration

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

ui

Testing

manually tested

Refers/Fixes

Fixes #1004

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #1070 into master will decrease coverage by 0.12%.
The diff coverage is 8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1070      +/-   ##
=========================================
- Coverage   32.02%   31.9%   -0.13%     
=========================================
  Files         105     105              
  Lines        7247    7269      +22     
  Branches      941     947       +6     
=========================================
- Hits         2321    2319       -2     
- Misses       4818    4842      +24     
  Partials      108     108
Impacted Files Coverage Δ
app/marketing/views.py 15.52% <8%> (-1.23%) ⬇️
app/app/settings.py 80.79% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39df6fb...cdad3b7. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkdarkdragon Thanks for the contribution!
Overall, lgtm.

I am going to make a few adjustments to this post-merge to DRY it up a bit and move some of the business logic out of the view.

Thanks again!

@mbeacom mbeacom merged commit 3a166f4 into gitcoinco:master May 5, 2018
mbeacom added a commit that referenced this pull request May 5, 2018
matthewlilley pushed a commit to matthewlilley/web that referenced this pull request May 11, 2018
matthewlilley pushed a commit to matthewlilley/web that referenced this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants