ant token name did not show up #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 31.91% 31.89% -0.02%
==========================================
Files 105 105
Lines 7301 7308 +7
Branches 953 955 +2
==========================================
+ Hits 2330 2331 +1
- Misses 4862 4868 +6
Partials 109 109
Continue to review full report at Codecov.
|
|
screenshot of the fix working http://bits.owocki.com/3H1i3w0x3T1F/Screen%20Shot%202018-05-08%20at%208.30.00%20AM.png |
mbeacom
reviewed
May 8, 2018
| if not token_name: | ||
| token = addr_to_token(token_address) | ||
| if token: | ||
| token_name = token['name'] |
mbeacom
approved these changes
May 8, 2018
thelostone-mc
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitcoin.co/funding/details?url=https://github.com/aragon
fix for the denomination not showing up here