-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ant token name did not show up #1108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 31.91% 31.89% -0.02%
==========================================
Files 105 105
Lines 7301 7308 +7
Branches 953 955 +2
==========================================
+ Hits 2330 2331 +1
- Misses 4862 4868 +6
Partials 109 109
Continue to review full report at Codecov.
|
screenshot of the fix working http://bits.owocki.com/3H1i3w0x3T1F/Screen%20Shot%202018-05-08%20at%208.30.00%20AM.png |
if not token_name: | ||
token = addr_to_token(token_address) | ||
if token: | ||
token_name = token['name'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit messages :')
https://gitcoin.co/funding/details?url=https://github.com/aragon
fix for the denomination not showing up here