Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style refresh quote button #1114

Merged
merged 1 commit into from
May 10, 2018
Merged

Conversation

arku
Copy link
Contributor

@arku arku commented May 9, 2018

Description

Styles 'Refresh Quote' button in the funding page. Also adds a margin to the quote author element.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #1114 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage    31.7%   31.66%   -0.05%     
==========================================
  Files         105      105              
  Lines        7352     7352              
  Branches      970      970              
==========================================
- Hits         2331     2328       -3     
- Misses       4912     4915       +3     
  Partials      109      109
Impacted Files Coverage Δ
app/app/settings.py 80.79% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ddb10...07d1a03. Read the comment docs.

@mbeacom mbeacom added the frontend This needs frontend expertise. label May 9, 2018
@thelostone-mc
Copy link
Member

@arun1595 could you add in a screenshot ?

@arku
Copy link
Contributor Author

arku commented May 9, 2018

@thelostone-mc Not sure how to access the funding page without creating a transaction. Let me see if I can render a static page with the random quote generator. If you've got an idea, do let me know!

@arku
Copy link
Contributor Author

arku commented May 9, 2018

@thelostone-mc Here you go :)

image

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 60913fe into gitcoinco:master May 10, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.018 ETH (13.66 USD @ $759.16/ETH) has been granted to @arun1595 for this issue from Gitcoin Core. ⚡️

The sender had the following public comments:

Thanks for the contribution and welcome to the community! 🙌

Nice work @arun1595! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@arku arku deleted the refresh-quote branch May 10, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants