fix for 'accept submission' not showing up #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
May 20, 2018
| @@ -300,8 +300,14 @@ var callbacks = { | |||
|
|
|||
| var isBountyOwner = function(result) { | |||
| var bountyAddress = result['bounty_owner_address']; | |||
| if(typeof web3 == 'undefined' ){ | |||
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
There should be no spaces inside this paren. (space-in-parens)
Missing space before opening brace. (space-before-blocks)
| if(typeof web3 == 'undefined' ){ | ||
| return false; | ||
| } | ||
| if(typeof web3.eth.coinbase == 'undefined' || !web3.eth.coinbase ){ |
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
There should be no spaces inside this paren. (space-in-parens)
Missing space before opening brace. (space-before-blocks)
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 31.66% 31.85% +0.19%
==========================================
Files 115 115
Lines 7933 8117 +184
Branches 1038 1098 +60
==========================================
+ Hits 2512 2586 +74
- Misses 5311 5409 +98
- Partials 110 122 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://gitcoincommunity.slack.com/files/UAPHNE3JT/FAT1U80LD/screen_shot_2018-05-19_at_22.06.35.png
at least i think this might be a fix.. not totally sure