GDPR: Management command to send email to all gitcoin users #1252

SaptakS · 2018-05-24T11:52:49Z

Description

Management command so that we can send the GDPR policy update email to all the subscribed users of gitcoin

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

management

Testing

Run ./manage.py gdpr_update_email --live
The email will be sent if sendgrid is setup.

Screenshot of HTML:

Refers/Fixes

FIxes #1242

stickler-ci · 2018-05-24T11:53:29Z

app/marketing/management/commands/gdpr_update_email.py

@@ -0,0 +1,81 @@
+'''
+    Copyright (C) 2017 Gitcoin Core 


W291 trailing whitespace

stickler-ci · 2018-05-24T11:53:29Z

app/marketing/management/commands/gdpr_update_email.py

+from marketing.mails import gdpr_update
+from marketing.models import EmailSubscriber
+
+warnings.filterwarnings("ignore", category=DeprecationWarning) 


W291 trailing whitespace

codecov · 2018-05-24T12:08:17Z

Codecov Report

Merging #1252 into master will decrease coverage by 0.2%.
The diff coverage is 5.66%.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
- Coverage   31.57%   31.37%   -0.21%     
==========================================
  Files         118      119       +1     
  Lines        8186     8239      +53     
  Branches     1065     1072       +7     
==========================================
  Hits         2585     2585              
- Misses       5491     5544      +53     
  Partials      110      110

Impacted Files	Coverage Δ
...marketing/management/commands/gdpr_update_email.py	`0% <0%> (ø)`
app/retail/emails.py	`22.5% <28.57%> (+0.22%)`	⬆️
app/marketing/mails.py	`13% <8.33%> (-0.2%)`	⬇️
app/app/settings.py	`83.61% <0%> (-1.7%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84babc3...7ea2e8f. Read the comment docs.

mbeacom · 2018-05-24T12:15:27Z

app/retail/templates/emails/gdpr_update.html

+<h1>{% trans "Gitcoin: Updated Terms & Policies" %}</h1>
+<div style="text-align: left! important">
+    <p>
+        {% trans "Hello" %} {{subscriber}},


Just a note... we should get into the habit of using {{ var }} formatted variables in django templates.

I know. But since I saw this is the format followed most placed, so I thought of sticking with it to maintain uniformity. I literally changed from {{ var }} to {{var}} 😋

This is @mbeacom when me and @SaptakS try to help out

mbeacom · 2018-05-24T12:16:44Z

app/marketing/management/commands/gdpr_update_email.py

+        counter = 0
+        for to_email in email_list:
+            counter += 1
+            print("-sending {} / {}".format(counter, to_email))


We could remove .format here with: print('-sending, counter, '/', to_email) or print(f'-sending {counter} / {to_email}')

mbeacom · 2018-05-24T12:18:51Z

app/marketing/management/commands/gdpr_update_email.py

+        queryset = queryset.order_by('email')
+        email_list = set(queryset.values_list('email', flat=True))
+
+        print("got {} emails".format(len(email_list)))


Could eliminate .format here: print('got', len(email_list), 'emails') or `print(f'got {len(email_list)} emails')

mbeacom · 2018-05-24T12:19:35Z

app/marketing/management/commands/gdpr_update_email.py

+        )
+
+    def handle(self, *args, **options):
+


No new line between method and beginning logic/docstrings.

mbeacom · 2018-05-24T12:22:16Z

app/retail/templates/emails/gdpr_update.html

+        {% trans "As always, the entire Gitcoin team works every day to make Gitcoin a safe and trustworthy place to grow open source. We invite you to learn more about our outlined updates to our Policies and Terms of Use: " %}
+    </p>
+    <ul>
+        <li>{% blocktrans %}<a href="{{terms_of_use_link}}">Our updated Terms of Use </a>{% endblocktrans %}</li>


To avoid issues with autogeneration of translations, I've been trying to avoid wrapping dynamic vars in blocktrans. We could update this to:
<li><a href="{{ terms_of_use_link }}">{% trans "Our updated Terms of Use" %} </a></li>

mbeacom · 2018-05-24T12:25:05Z

app/retail/emails.py

@@ -297,6 +297,22 @@ def render_bounty_startwork_expired(to_email, bounty, interest, time_delta_days)
    return response_html, response_txt


+def render_gdpr_update(to_email):
+


No new line here

mbeacom · 2018-05-24T12:25:33Z

app/retail/emails.py

+
+    params = {
+        'subscriber': get_or_save_email_subscriber(to_email, 'internal'),
+        'terms_of_use_link': '',


Should these params have value to reverses of their relevant urls?

Yes. I was about to comment. But all the links are still not active in the master branch. Hence I will add them once the other PRs get merged.

stickler-ci · 2018-05-24T13:33:47Z

app/retail/emails.py

+def render_gdpr_update(to_email):
+    params = {
+        'subscriber': get_or_save_email_subscriber(to_email, 'internal'),
+        'terms_of_use_link': '', #TODO


E261 at least two spaces before inline comment
E262 inline comment should start with '# '

stickler-ci · 2018-05-24T13:33:47Z

app/retail/emails.py

+    params = {
+        'subscriber': get_or_save_email_subscriber(to_email, 'internal'),
+        'terms_of_use_link': '', #TODO
+        'privacy_policy_link': '', #TODO


E261 at least two spaces before inline comment
E262 inline comment should start with '# '

stickler-ci · 2018-05-24T13:33:47Z

app/retail/emails.py

+        'subscriber': get_or_save_email_subscriber(to_email, 'internal'),
+        'terms_of_use_link': '', #TODO
+        'privacy_policy_link': '', #TODO
+        'cookie_policy_link': '', #TODO


E261 at least two spaces before inline comment
E262 inline comment should start with '# '

owocki · 2018-05-24T16:19:18Z

note: we should not send this email to users who have previously opted out of newsletters.

that should mean that if their es.preferences['level'] is ['lite', 'lite1', 'regular', 'nothing'] we don't send it (in the old schema). in the new schema, if they receive roundup emails should dictate if they recevie these emails

owocki · 2018-05-24T17:55:18Z

i believe we need to send this today

owocki · 2018-05-24T17:56:05Z

app/retail/emails.py

+def render_gdpr_update(to_email):
+    params = {
+        'subscriber': get_or_save_email_subscriber(to_email, 'internal'),
+        'terms_of_use_link': '',  # TODO


these need to be filled in

probably https://gitcoin.co/legal/xxxx

SaptakS · 2018-05-24T20:10:08Z

@owocki @mbeacom I have added links and also the suppression check same as the roundup, so should be good to go.

stickler-ci · 2018-05-24T20:33:43Z

app/retail/emails.py

@@ -23,6 +23,7 @@
 from django.contrib.admin.views.decorators import staff_member_required
 from django.http import HttpResponse
 from django.shortcuts import redirect
+from django.urls import reverse


F401 'django.urls.reverse' imported but unused

SaptakS requested a review from owocki May 24, 2018 11:52

ghost assigned SaptakS May 24, 2018

ghost added the in progress label May 24, 2018

stickler-ci reviewed May 24, 2018

View reviewed changes

SaptakS force-pushed the gdpr/community-email-management branch from 9fb6e7c to 5a1f63a Compare May 24, 2018 12:08

mbeacom reviewed May 24, 2018

View reviewed changes

SaptakS force-pushed the gdpr/community-email-management branch from 5a1f63a to 6a296f8 Compare May 24, 2018 12:26

GDPR: Management command to send email to all gitcoin users

82dbf51

SaptakS force-pushed the gdpr/community-email-management branch from 6a296f8 to 82dbf51 Compare May 24, 2018 12:36

Merge branch 'master' into pr/1252

ba1f364

ghost assigned mbeacom May 24, 2018

Fix isort

d2cd5de

mbeacom previously approved these changes May 24, 2018

View reviewed changes

SaptakS dismissed mbeacom’s stale review via 8eddd48 May 24, 2018 13:33

stickler-ci reviewed May 24, 2018

View reviewed changes

Add To Do for the links

86b9700

SaptakS force-pushed the gdpr/community-email-management branch from 0260d0b to 86b9700 Compare May 24, 2018 13:40

owocki reviewed May 24, 2018

View reviewed changes

Add the links in the email

4b3112d

Adds suppression check same as roundup

145d2c4

SaptakS force-pushed the gdpr/community-email-management branch from b26110d to 145d2c4 Compare May 24, 2018 20:19

stickler-ci reviewed May 24, 2018

View reviewed changes

Update the content of the email

7ea2e8f

SaptakS force-pushed the gdpr/community-email-management branch from feeffaf to 7ea2e8f Compare May 24, 2018 20:35

mbeacom approved these changes May 24, 2018

View reviewed changes

mbeacom merged commit d665bb8 into gitcoinco:master May 24, 2018

ghost removed the in progress label May 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GDPR: Management command to send email to all gitcoin users #1252

GDPR: Management command to send email to all gitcoin users #1252

SaptakS commented May 24, 2018

stickler-ci May 24, 2018

stickler-ci May 24, 2018

codecov bot commented May 24, 2018 •

edited

Loading

mbeacom May 24, 2018

SaptakS May 24, 2018

thelostone-mc May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

mbeacom May 24, 2018

SaptakS May 24, 2018

stickler-ci May 24, 2018

stickler-ci May 24, 2018

stickler-ci May 24, 2018

owocki commented May 24, 2018

owocki commented May 24, 2018

owocki May 24, 2018

SaptakS commented May 24, 2018

stickler-ci May 24, 2018

		@@ -297,6 +297,22 @@ def render_bounty_startwork_expired(to_email, bounty, interest, time_delta_days)
		return response_html, response_txt


		def render_gdpr_update(to_email):

GDPR: Management command to send email to all gitcoin users #1252

GDPR: Management command to send email to all gitcoin users #1252

Conversation

SaptakS commented May 24, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 24, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented May 24, 2018

owocki commented May 24, 2018

Choose a reason for hiding this comment

SaptakS commented May 24, 2018

Choose a reason for hiding this comment

codecov bot commented May 24, 2018 •

edited

Loading