Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitches fixes and overall better buttons look and feel #127

Merged
merged 2 commits into from
Dec 15, 2017

Conversation

algae12
Copy link

@algae12 algae12 commented Dec 15, 2017

Fixes: #126

Changes:

Site-wide changes:

  • I removed the raise class from all buttons to fix glitches. In all buttons that used to contain that class, interactivity is now indicated by a contrast change.

Specific changes:

  • Hero buttons:
    Old:
    old_hero
    New:
    new_hero

  • Carousel buttons.
    Old:
    old_car
    New:
    new_car

  • Email submit form.
    Old:
    old_submit
    New:
    new_submit

@codecov
Copy link

codecov bot commented Dec 15, 2017

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   12.25%   12.25%           
=======================================
  Files          65       65           
  Lines        3067     3067           
  Branches      339      339           
=======================================
  Hits          376      376           
  Misses       2691     2691

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8724ea6...671c1f2. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Dec 15, 2017

amazing :) digging in on this now

@owocki
Copy link
Contributor

owocki commented Dec 15, 2017

awesome!

@owocki owocki merged commit 405af72 into gitcoinco:master Dec 15, 2017
@owocki
Copy link
Contributor

owocki commented Dec 15, 2017

what do you think of the interior buttons a la http://localhost:8080/funding/new ?

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH ($33.89) has been granted to @algae12 for this issue. ⚡️

The sender had the following public comments:

these buttons are awesome 🚀

Nice work @algae12, check your email for further instructions.

@algae12
Copy link
Author

algae12 commented Dec 15, 2017

@owocki Thanks for the tip! Glad you like them 😊
In regards to the interior buttons, I’ve got some redesign ideas for the issue pages and browser, this redesign will include some new shiny buttons ⚡️
Going to start working on some mockups after the weekend. I’ll drop them by the slack design channel as soon as they’re ready.

@owocki
Copy link
Contributor

owocki commented Dec 15, 2017 via email

@owocki
Copy link
Contributor

owocki commented Dec 18, 2017

unexpected consequence on the accept/reject page. http://bits.owocki.com/3n0w2a173r1f/Screen%20Shot%202017-12-17%20at%2010.39.42%20PM.png

looking forward to the PR for button updates on internal portion of site

@algae12 algae12 deleted the hotfix/better-btns-look-and-feel branch December 18, 2017 10:49
@algae12
Copy link
Author

algae12 commented Dec 18, 2017

@owocki Oops, sorry about that. Fixed and waiting for approval.

ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018
…-and-feel

Glitches fixes and overall better buttons look and feel
owocki pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the buttons are glitchy and unpolished.
3 participants