-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENS: Ensure 10%+ gas minimum #1303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 31.29% 32.26% +0.96%
==========================================
Files 122 123 +1
Lines 8521 9132 +611
Branches 1116 1287 +171
==========================================
+ Hits 2667 2946 +279
- Misses 5743 6065 +322
- Partials 111 121 +10
Continue to review full report at Codecov.
|
app/enssubdomain/views.py
Outdated
# to "0x7bce7e4bcd2fea4d26f3d254bb8cf52b9ee8dd7353b19bfbc86803c27d9bbf39" | ||
txn_hash = str(binascii.b2a_hex(txn_hash)).replace("b'", "0x").rstrip("'") | ||
except ValueError: | ||
logger.warning('Error in set_address_at_resolver') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we not log the exception too?
Description
The goal of this PR is to resolve: #1302 (https://rollbar.com/gitcoin/gitcoin/items/1176/)
Explanation of fix
Checklist
Affected core subsystem(s)
ens
Refers/Fixes
Fix #1302