-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolbox: avoid $.get when url is undefined #1325
Conversation
Fixes the failed
@owocki Can't we just directly do |
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 30.83% 30.83%
=======================================
Files 124 124
Lines 8738 8738
Branches 1146 1146
=======================================
Hits 2694 2694
Misses 5933 5933
Partials 111 111 Continue to review full report at Codecov.
|
@kziemianek completed the original bounty for this. Any thoughts? |
@thelostone-mc @mbeacom I am removing the |
Seems the $.get for document preloads was actually not doing anything.
Sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIPPITTTT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Issue
Checklist
Affected core subsystem(s)