Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim issue action plan before validation #1338

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jun 1, 2018

Description

Trims the whitespaces in the action plan before validation forcing the user to enter a string as the issue plan.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UX

Refers/Fixes

Fixes #1336

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #1338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   30.82%   30.82%           
=======================================
  Files         124      124           
  Lines        8740     8740           
  Branches     1146     1146           
=======================================
  Hits         2694     2694           
  Misses       5935     5935           
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e9131...ded90dc. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc added the frontend This needs frontend expertise. label Jun 2, 2018
@thelostone-mc
Copy link
Member

Thanks @arun1595 ^_^

@thelostone-mc thelostone-mc merged commit 0964dc3 into gitcoinco:master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty user comments should be handled on gitcoinbot
2 participants