add 'stop work & slash' button #1343

jvmaia · 2018-06-02T15:21:18Z

Description

implement the 'stop work & slash' feature

Refers/Fixes

codecov · 2018-06-02T15:24:57Z

Codecov Report

Merging #1343 into master will decrease coverage by 0.02%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   30.27%   30.25%   -0.03%     
==========================================
  Files         125      125              
  Lines        9003     9041      +38     
  Branches     1156     1160       +4     
==========================================
+ Hits         2726     2735       +9     
- Misses       6169     6197      +28     
- Partials      108      109       +1

Impacted Files	Coverage Δ
app/dashboard/views.py	`15.6% <0%> (-0.15%)`	⬇️
app/dashboard/models.py	`56.54% <100%> (+0.03%)`	⬆️
app/dashboard/router.py	`31.73% <0%> (-1.95%)`	⬇️
app/retail/utils.py	`22.5% <0%> (-0.36%)`	⬇️
app/marketing/management/commands/pull_stats.py	`0% <0%> (ø)`	⬆️
app/retail/views.py	`39.41% <0%> (ø)`	⬆️
app/dashboard/helpers.py	`26.98% <0%> (+0.46%)`	⬆️
app/dashboard/utils.py	`29.09% <0%> (+0.71%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243190c...6e13c50. Read the comment docs.

jvmaia · 2018-06-04T02:58:16Z

The code is losing ~0.07% because the if/else statement in dashboard/views.py is extended. I can write it in one line, but i don't know if it would be a good idea.

owocki · 2018-06-04T22:51:34Z

reviewing now

owocki

just tested. code looks good.. seems to be working @mbeacom what do you think

mbeacom

Generally, lgtm. Any reason for using an int in the url path versus a param?

jvmaia · 2018-06-06T17:21:43Z

Not a big game changer, but using a int in url we can reduce the size of the if/else statement inside views.uninterested().

SaptakS · 2018-06-06T19:35:43Z

app/assets/v2/js/shared.js

+  var slashed = '0';
+  var success_message = 'Contributor removed from bounty.';
+
+  if (slash) {


I think it's better to send true and false instead of 0 and 1. And then here you can write something like if slash == 'true' ? cc: @mbeacom

I feel int just reduces readibility and also there is no specific meaning of 0 and 1 from the url itslef. So I am not very comfortable with this.

I agree with this. Additionally, we could probably swap this out to simply use a POST param versus the URL defined variable, defaulting to False if the request.POST param isn't present.

Updating the code to use a POST param, as the @mbeacom said.

Do you think it's better send the POST param only when the slash is true? Makes more sense to me always send it.

mbeacom · 2018-06-06T19:38:21Z

@owocki Are we married to "slash" here? Thoughts on alter_rep / ding_rep or something like that? After discussing it with @SaptakS, slash seems fairly misleading, since we use slash in multiple places to represent the presence of / and might prove difficult to maintain or approach by community members that are unfamiliar with the terminology.

Note: I understand the hunter wrote this to the spec, so I wouldn't expect him to modify this. Just something we might want to consider before we push it live.

stickler-ci · 2018-06-06T21:25:27Z

app/dashboard/views.py

@@ -347,7 +350,10 @@ def uninterested(request, bounty_id, profile_id):
        bounty.interested.remove(interest)
        maybe_market_to_slack(bounty, 'stop_work')
        maybe_market_to_user_slack(bounty, 'stop_work')
-        event_name = "bounty_removed_by_staff" if is_staff else "bounty_removed_by_funder"
+        if is_staff:
+            event_name = "bounty_removed_slashed_by_staff" if request.POST['slashed'] == 'true' else "bounty_removed_by_staff"


E501 line too long (126 > 120 characters)

mbeacom · 2018-06-06T23:19:47Z

app/dashboard/views.py

@@ -342,12 +345,16 @@ def uninterested(request, bounty_id, profile_id):
            {'error': 'Only bounty funders are allowed to remove users!'},
            status=401)

+    slashed = request.POST['slashed'] == 'true'


You could do: slashed = request.POST.get('slashed') here and you would only need to pass slashed if it's a reputation adverse event.

Thanks for the tip!

mbeacom · 2018-06-06T23:22:02Z

app/app/urls.py

@@ -84,7 +84,7 @@
    path('actions/bounty/<int:bounty_id>/interest/new/', dashboard.views.new_interest, name='express-interest'),
    path('actions/bounty/<int:bounty_id>/interest/remove/', dashboard.views.remove_interest, name='remove-interest'),
    path(
-        'actions/bounty/<int:bounty_id>/interest/<int:profile_id>/uninterested/',
+        'actions/bounty/<int:bounty_id>/interest/<int:profile_id>/uninterested/<int:slash>/',


Can we drop the additional var in this URL?

Yep, code updated!

stickler-ci · 2018-06-07T17:20:22Z

app/assets/v2/js/shared.js

@@ -220,13 +230,21 @@ var mutate_interest = function(bounty_pk, direction, data) {
 };


-var uninterested = function(bounty_pk, profileId) {
+var uninterested = function(bounty_pk, profileId, slash) {
+  var data = {}


Missing semicolon. (semi)

owocki · 2018-06-08T17:02:11Z

@owocki Are we married to "slash" here? Thoughts on alter_rep / ding_rep or something like that? After discussing it with @SaptakS, slash seems fairly misleading, since we use slash in multiple places to represent the presence of / and might prove difficult to maintain or approach by community members that are unfamiliar with the terminology.

Note: I understand the hunter wrote this to the spec, so I wouldn't expect him to modify this. Just something we might want to consider before we push it live.

I just used slash bc its what Vlad Zamfir uses as a verb when he talks about Proof of Stake. I'm not married to it; and I don't feel strongly in either direction (as this is an admin only functionality)

jvmaia added 2 commits June 2, 2018 12:14

add 'stop work & slash' button

bbade0c

Merge branch 'master' of https://github.com/jvmaia/web

af64c65

add padding to stop work buttons & fix the user's stop work

ef0f2ba

gitcoinbot mentioned this pull request Jun 4, 2018

Admin: Stop Work + Stop Work & Slash #1340

Closed

name method correctly

8b961fe

ghost assigned owocki Jun 4, 2018

ghost added the in progress label Jun 4, 2018

Merge branch 'master' into jvmaia_master

750732f

owocki previously approved these changes Jun 4, 2018

View reviewed changes

mbeacom reviewed Jun 6, 2018

View reviewed changes

SaptakS reviewed Jun 6, 2018

View reviewed changes

use post param instead of url defined variable at views.uninterested

ab61f4c

jvmaia dismissed owocki’s stale review via ab61f4c June 6, 2018 21:24

stickler-ci reviewed Jun 6, 2018

View reviewed changes

fix line length

4c2f88d

mbeacom suggested changes Jun 7, 2018

View reviewed changes

mbeacom added waiting on contributor labels Jun 7, 2018

mbeacom changed the title ~~add 'stop work & slash' button~~ WIP: add 'stop work & slash' button Jun 7, 2018

remove useless var in url

6b20b2c

stickler-ci reviewed Jun 7, 2018

View reviewed changes

add semicolon

6e13c50

owocki merged commit 1d5af4a into gitcoinco:master Jun 12, 2018

ghost removed the in progress label Jun 12, 2018

mbeacom changed the title ~~WIP: add 'stop work & slash' button~~ add 'stop work & slash' button Jun 13, 2018

mbeacom removed waiting on contributor labels Jun 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add 'stop work & slash' button #1343

add 'stop work & slash' button #1343

jvmaia commented Jun 2, 2018

codecov bot commented Jun 2, 2018 •

edited

Loading

jvmaia commented Jun 4, 2018

owocki commented Jun 4, 2018

owocki left a comment

mbeacom left a comment

jvmaia commented Jun 6, 2018 •

edited

Loading

SaptakS Jun 6, 2018 •

edited

Loading

mbeacom Jun 6, 2018

jvmaia Jun 6, 2018

jvmaia Jun 6, 2018 •

edited

Loading

mbeacom commented Jun 6, 2018 •

edited

Loading

stickler-ci Jun 6, 2018

mbeacom Jun 6, 2018

jvmaia Jun 7, 2018

mbeacom Jun 6, 2018

jvmaia Jun 7, 2018

stickler-ci Jun 7, 2018

owocki commented Jun 8, 2018

add 'stop work & slash' button #1343

add 'stop work & slash' button #1343

Conversation

jvmaia commented Jun 2, 2018

Description

Refers/Fixes

codecov bot commented Jun 2, 2018 • edited Loading

Codecov Report

jvmaia commented Jun 4, 2018

owocki commented Jun 4, 2018

owocki left a comment

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

jvmaia commented Jun 6, 2018 • edited Loading

SaptakS Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jvmaia Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

mbeacom commented Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jun 8, 2018

codecov bot commented Jun 2, 2018 •

edited

Loading

jvmaia commented Jun 6, 2018 •

edited

Loading

SaptakS Jun 6, 2018 •

edited

Loading

jvmaia Jun 6, 2018 •

edited

Loading

mbeacom commented Jun 6, 2018 •

edited

Loading