Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement bounty info view on the bounty details page #1384

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jun 6, 2018

Description

In the below screenshot from desktop view, the 'Project Type' subheading and the value 'Traditional' look unassociated when they are in fact related. The PR attempts to fix it by making sure the info items always go together. In the mobile view, the items are rendered one in a row.

Before

image

image

After

image

image

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI

/cc @PixelantDesign

@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #1384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   30.25%   30.25%           
=======================================
  Files         125      125           
  Lines        9013     9013           
  Branches     1157     1157           
=======================================
  Hits         2727     2727           
  Misses       6178     6178           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367eb76...270d6cb. Read the comment docs.

SaptakS
SaptakS previously approved these changes Jun 6, 2018
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@thelostone-mc
Copy link
Member

Added some breathing space

screen shot 2018-06-06 at 12 48 44 pm

@thelostone-mc thelostone-mc merged commit 34f955a into gitcoinco:master Jun 6, 2018
@ghost ghost removed the in progress label Jun 6, 2018
@PixelantDesign
Copy link
Contributor

Thank you!

@arku arku deleted the bounty-info-enhancement branch June 6, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants