External links should open in new tab with noreferrer and noopener #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 30.26% 30.26%
=======================================
Files 125 125
Lines 9038 9038
Branches 1159 1159
=======================================
Hits 2735 2735
Misses 6194 6194
Partials 109 109Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to most UX studies, external links should open in a new tab. Some of the links weren't following this. So modified them.
Also, wherever we use
target=_blankwe should also addrel="noopener noreferrer"because of the most underetimated vulnerability. Fixed few of those too.Checklist
Affected core subsystem(s)
Links