Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django logger and deploy script handling #1437

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 11, 2018

Description

The goal of this PR is to disable the mail_admins log handler for all environments except prod and add granular control to other steps (crontab, etc) in the deploy.bash script.

Additionally, this allows us to disable the crontab update step (for staging) to avoid the mushrooming sync_geth.log.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

deploy

Testing

Local and stage

@mbeacom mbeacom added the backend This needs backend expertise. label Jun 11, 2018
@mbeacom mbeacom self-assigned this Jun 11, 2018
@mbeacom mbeacom requested a review from owocki June 11, 2018 21:53
@ghost ghost added the in progress label Jun 11, 2018
@codecov
Copy link

codecov bot commented Jun 11, 2018

Codecov Report

Merging #1437 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
- Coverage   30.26%   30.25%   -0.02%     
==========================================
  Files         125      125              
  Lines        9051     9054       +3     
  Branches     1161     1162       +1     
==========================================
  Hits         2739     2739              
- Misses       6203     6206       +3     
  Partials      109      109
Impacted Files Coverage Δ
app/app/settings.py 81.76% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883c08f...828709e. Read the comment docs.

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test but LGTM

@owocki owocki merged commit 1e99317 into master Jun 12, 2018
@ghost ghost removed the in progress label Jun 12, 2018
@mbeacom mbeacom deleted the deploy-script-updates branch June 12, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants