Issue Explorer Check in tools for Admin (Vivek) #1446

owocki · 2018-06-12T22:07:38Z

Description

Issue Explorer Check in tools for Admin (Vivek)

Per my convo with Vivek on our checkin today, we need a better way to make the issue explorer checkin scale. This PR adds five buttons to each bounty for admins only

suspends auto approval (approval required bounties only)
hide bounty -- hides/removes it from our system
toggle remarket ready -- marks the bounty as priority to be promoted
contact funder -- prompts user for some text and then sends an email on their behalf containing that text
snooze gitcoinbot -- snoozes gitcoinbot

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

bounties, admin

Testing

tested each function

Refers/Fixes

Self, convo I had with Vivek this am

stickler-ci · 2018-06-12T22:08:10Z

app/assets/v2/js/pages/bounty_details.js

@@ -655,6 +670,69 @@ var do_actions = function(result) {

      actions.push(_entry);
    }
+    if (show_suspend_auto_approval) {
+      var url = result['url'] + '?suspend_auto_approval=1';


'url' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:08:10Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_suspend_auto_approval) {
+      var url = result['url'] + '?suspend_auto_approval=1';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:08:10Z

app/assets/v2/js/pages/bounty_details.js

+
+      var _entry = {
+        enabled: true,
+        href: url,


'url' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:08:10Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:08:10Z

app/assets/v2/js/pages/bounty_details.js

+    }
+
+    if (show_admin_override_and_hide) {
+      var url = result['url'] + '?admin_override_and_hide=1';


'url' used outside of binding context. (block-scoped-var)
'url' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:08:13Z

app/dashboard/helpers.py

@@ -477,6 +477,8 @@ def create_new_bounty(old_bounties, bounty_payload, bounty_details, bounty_id):
                last_comment_date=latest_old_bounty.last_comment_date if latest_old_bounty else None,
                snooze_warnings_for_days=latest_old_bounty.snooze_warnings_for_days if latest_old_bounty else 0,
                admin_override_and_hide=latest_old_bounty.admin_override_and_hide if latest_old_bounty else 0,
+                admin_override_suspend_auto_approval=latest_old_bounty.admin_override_suspend_auto_approval if latest_old_bounty else 0,


E501 line too long (136 > 120 characters)

stickler-ci · 2018-06-12T22:08:13Z

app/dashboard/models.py

@@ -195,6 +195,8 @@ class Bounty(SuperModel):
    value_true = models.DecimalField(default=0, decimal_places=2, max_digits=50, blank=True, null=True)
    privacy_preferences = JSONField(default={}, blank=True)
    admin_override_and_hide = models.BooleanField(default=False, help_text=_('Admin override to hide the bounty from the system'))
+    admin_override_suspend_auto_approval = models.BooleanField(default=False, help_text=_('Admin override to suspend work auto approvals'))


E501 line too long (139 > 120 characters)

stickler-ci · 2018-06-12T22:08:13Z

app/dashboard/models.py

@@ -195,6 +195,8 @@ class Bounty(SuperModel):
    value_true = models.DecimalField(default=0, decimal_places=2, max_digits=50, blank=True, null=True)
    privacy_preferences = JSONField(default={}, blank=True)
    admin_override_and_hide = models.BooleanField(default=False, help_text=_('Admin override to hide the bounty from the system'))
+    admin_override_suspend_auto_approval = models.BooleanField(default=False, help_text=_('Admin override to suspend work auto approvals'))
+    admin_mark_as_remarket_ready = models.BooleanField(default=False, help_text=_('Admin override to mark as remarketing ready'))


E501 line too long (129 > 120 characters)

stickler-ci · 2018-06-12T22:08:13Z

app/dashboard/views.py

+                helper_handle_suspend_auto_approval(request, bounty)
+                helper_handle_mark_as_remarket_ready(request, bounty)
+                helper_handle_admin_contact_funder(request, bounty)
+


W293 blank line contains whitespace

stickler-ci · 2018-06-12T22:08:14Z

app/marketing/management/commands/pending_start_work_actions.py

    start_time = timezone.now() - timezone.timedelta(hours=(threshold+1))
    end_time = timezone.now() - timezone.timedelta(hours=(threshold))
    interests = Interest.objects.filter(pending=True, created__gt=start_time, created__lt=end_time)
    print(f"{interests.count()} {action_str}")
    for interest in interests:
-        bounty = interest.bounties.first()  # TODO is this right? is this how i get the bounty?
+        bounty = interest.bounties.first() 


W291 trailing whitespace

codecov · 2018-06-12T22:08:32Z

Codecov Report

Merging #1446 into master will decrease coverage by 0.14%.
The diff coverage is 15.18%.

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
- Coverage   30.28%   30.14%   -0.15%     
==========================================
  Files         125      125              
  Lines        9096     9166      +70     
  Branches     1166     1178      +12     
==========================================
+ Hits         2755     2763       +8     
- Misses       6232     6294      +62     
  Partials      109      109

Impacted Files	Coverage Δ
app/dashboard/helpers.py	`26.98% <ø> (ø)`	⬆️
.../management/commands/pending_start_work_actions.py	`0% <0%> (ø)`	⬆️
...arketing/management/commands/new_bounties_email.py	`0% <0%> (ø)`	⬆️
app/dashboard/models.py	`56.52% <100%> (+0.08%)`	⬆️
app/dashboard/views.py	`15.2% <11.62%> (-0.41%)`	⬇️
app/retail/emails.py	`21.14% <16.66%> (-0.1%)`	⬇️
...marketing/management/commands/remarket_bounties.py	`50% <28.57%> (ø)`
app/marketing/mails.py	`11.97% <8.33%> (-0.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13720b3...4b89623. Read the comment docs.

stickler-ci · 2018-06-12T22:09:03Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:09:04Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_admin_toggle_remarket) {
+      var url = result['url'] + '?admin_toggle_as_remarket_ready=1';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+    }
+
+    if (show_admin_snooze) {
+      var url = '';


'url' used outside of binding context. (block-scoped-var)
'url' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_admin_snooze) {
+      var url = '';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+
+      var _entry = {
+        enabled: true,
+        href: url,


'url' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:16:26Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only snooze_gitcoin_bot'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:24:47Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:24:47Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_admin_toggle_remarket) {
+      var url = result['url'] + '?admin_toggle_as_remarket_ready=1';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-12T22:24:47Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-12T22:24:47Z

app/assets/v2/js/pages/bounty_details.js

+
+      var _entry = {
+        enabled: true,
+        href: url,


'url' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:37:26Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:37:26Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_admin_toggle_remarket) {
+      var url = result['url'] + '?admin_toggle_as_remarket_ready=1';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-13T13:37:26Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:37:26Z

app/assets/v2/js/pages/bounty_details.js

+
+      var _entry = {
+        enabled: true,
+        href: url,


'url' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:48:05Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:48:05Z

app/assets/v2/js/pages/bounty_details.js

+    if (show_admin_toggle_remarket) {
+      var url = result['url'] + '?admin_toggle_as_remarket_ready=1';
+
+      var _entry = {


'_entry' used outside of binding context. (block-scoped-var)
'_entry' is already defined. (no-redeclare)

stickler-ci · 2018-06-13T13:48:05Z

app/assets/v2/js/pages/bounty_details.js

+        buttonclass: 'admin-only'
+      };
+
+      actions.push(_entry);


'_entry' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-06-13T13:48:06Z

app/assets/v2/js/pages/bounty_details.js

+
+      var _entry = {
+        enabled: true,
+        href: url,


'url' used outside of binding context. (block-scoped-var)

mbeacom

Generally, lgtm. I pushed a commit to consolidate the migration files and resolve the pytest failure. I'm not sure if we want to address the eslint warnings that stickler is commenting about, but 🚢

owocki added 4 commits June 12, 2018 15:37

suspend auto approval and hide bounty

961cd3d

remarket ready bounties

0a4e9ce

remarket ready bounties

3d11238

admin contact actions

56b92be

ghost assigned owocki Jun 12, 2018

ghost added the in progress label Jun 12, 2018

stickler-ci reviewed Jun 12, 2018

View reviewed changes

from email

41a0a2e

stickler-ci reviewed Jun 12, 2018

View reviewed changes

owocki requested review from PixelantDesign, thelostone-mc, mbeacom and vs77bb June 12, 2018 22:13

snooze

4d2d9e1

stickler-ci reviewed Jun 12, 2018

View reviewed changes

remarket bounties

71a6ec9

stickler-ci reviewed Jun 12, 2018

View reviewed changes

Consolidate migrations, line length, and cleanup whitespace

e3b8186

ghost assigned mbeacom Jun 13, 2018

stickler-ci reviewed Jun 13, 2018

View reviewed changes

Fix pytest

4b89623

stickler-ci reviewed Jun 13, 2018

View reviewed changes

mbeacom approved these changes Jun 13, 2018

View reviewed changes

owocki merged commit e7088a8 into master Jun 13, 2018

ghost removed the in progress label Jun 13, 2018

mbeacom deleted the kevin/staff_actions branch June 13, 2018 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue Explorer Check in tools for Admin (Vivek) #1446

Issue Explorer Check in tools for Admin (Vivek) #1446

owocki commented Jun 12, 2018 •

edited

Loading

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

codecov bot commented Jun 12, 2018 •

edited

Loading

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 12, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

stickler-ci Jun 13, 2018

mbeacom left a comment

Issue Explorer Check in tools for Admin (Vivek) #1446

Issue Explorer Check in tools for Admin (Vivek) #1446

Conversation

owocki commented Jun 12, 2018 • edited Loading

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 12, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

owocki commented Jun 12, 2018 •

edited

Loading

codecov bot commented Jun 12, 2018 •

edited

Loading