Fix pytest version #1495
Fix pytest version #1495
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
========================================
Coverage ? 28.3%
========================================
Files ? 125
Lines ? 9233
Branches ? 1188
========================================
Hits ? 2613
Misses ? 6523
Partials ? 97
Continue to review full report at Codecov.
|
|
@mbeacom I am not entirely sure how it was working but I think in latest pytest, they don't allow environment variables to be declared in the |
| @@ -36,6 +36,7 @@ jobs: | |||
| - codecov | |||
| env: | |||
| - PYTHONPATH="${TRAVIS_BUILD_DIR}/app/" | |||
| - DJANGO_SETTINGS_MODULE="app.settings" | |||
There was a problem hiding this comment.
Yes. Seems so. The environment variable declaration in setup.cfg under tool:pytest seems to not been working most probably in the newer versions. They need the environment variables to be set before the pytest can be run. Without this travis fails.
| @@ -1,5 +1,5 @@ | |||
| -r base.txt | |||
| pytest==3.5.0 | |||
| pytest>3.5.0 | |||
There was a problem hiding this comment.
Should we just pin this to the appropriate version or completely drop the version pinning for pytest?
There was a problem hiding this comment.
I think dropping version pinning is better. Pinning is what caused a problem here. I would have however done >=. But that might not upgrade the package installed because the current 3.5.0 will anyways satisfy.
Description
@owocki @leonprou this should fix the travis error in pytest.
@mbeacom review.
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes
Fixes #1492
Refs #1491