Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds OZR token #1596

Merged
merged 2 commits into from
Jul 3, 2018
Merged

adds OZR token #1596

merged 2 commits into from
Jul 3, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 2, 2018

per @ecorpnu request

@ghost ghost assigned owocki Jul 2, 2018
@ghost ghost added the in progress label Jul 2, 2018
@owocki owocki mentioned this pull request Jul 2, 2018
2 tasks
@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

#155 (comment)

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

@ecorpnu here ya go

@@ -173,7 +173,8 @@ var tokens = function(network_id) {
{ 'addr': '0x58b6a8a3302369daec383334672404ee733ab239', 'name': 'LPT', 'decimals': 18 },
{ 'addr': '0x09617f6fd6cf8a71278ec86e23bbab29c04353a7', 'name': 'ULT', 'decimals': 18 },
{ 'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8 },
{ 'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18 }
{ 'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18 },
{ "addr": "0x7338809d1a2c6fbb6e755470ab2a28e8c5dac63c", "name": "OZR", "decimals": 18},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote. (quotes)
Unexpected trailing comma. (comma-dangle)

@@ -174,7 +174,8 @@ var tokens = function(network_id) {
{'addr': '0x58b6a8a3302369daec383334672404ee733ab239', 'name': 'LPT', 'decimals': 18},
{'addr': '0x09617f6fd6cf8a71278ec86e23bbab29c04353a7', 'name': 'ULT', 'decimals': 18},
{'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8},
{'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18}
{'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18},
{"addr": "0x7338809d1a2c6fbb6e755470ab2a28e8c5dac63c", "name": "OZR", "decimals": 18},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote. (quotes)
Unexpected trailing comma. (comma-dangle)

Copy link

@ecorpnu ecorpnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake it should be single quote not double .

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #1596 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
- Coverage   29.93%   29.82%   -0.12%     
==========================================
  Files         130      130              
  Lines        9596     9766     +170     
  Branches     1243     1297      +54     
==========================================
+ Hits         2873     2913      +40     
- Misses       6619     6743     +124     
- Partials      104      110       +6
Impacted Files Coverage Δ
app/dashboard/tokens.py 100% <ø> (ø) ⬆️
app/dashboard/views.py 16.5% <0%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0c91b...532cd7e. Read the comment docs.

@ghost ghost assigned mbeacom Jul 3, 2018
@mbeacom mbeacom merged commit 9497dae into master Jul 3, 2018
@mbeacom mbeacom deleted the ozr_token branch July 3, 2018 19:42
@ghost ghost removed the in progress label Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants