Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Joseph's testimonial #1611

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Add Joseph's testimonial #1611

merged 2 commits into from
Jul 4, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jul 4, 2018

Description

Adds Joseph's testimonial to the landing page.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines

/cc @owocki

@@ -50,6 +50,9 @@ def index(request):
("Piper", static("v2/images/testimonials/pipermerriam.jpg"),
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."),
'https://github.com/pipermerriam', 'Pipermerriam'),
("Joseph Schiarizzi", static("v2/images/testimonials/jschiarizzi.jpeg"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E131 continuation line unaligned for hanging indent

@@ -50,6 +50,9 @@ def index(request):
("Piper", static("v2/images/testimonials/pipermerriam.jpg"),
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."),
'https://github.com/pipermerriam', 'Pipermerriam'),
("Joseph Schiarizzi", static("v2/images/testimonials/jschiarizzi.jpeg"),
_("On a Friday I needed a front end done for a project due in 48 hours. When everyone I knew was busy, gitcoiners were able to help me make my deadline, with fast, affordable, & high quality work."),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E128 continuation line under-indented for visual indent
E501 line too long (209 > 120 characters)

@@ -50,6 +50,9 @@ def index(request):
("Piper", static("v2/images/testimonials/pipermerriam.jpg"),
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."),
'https://github.com/pipermerriam', 'Pipermerriam'),
("Joseph Schiarizzi", static("v2/images/testimonials/jschiarizzi.jpeg"),
_("On a Friday I needed a front end done for a project due in 48 hours. When everyone I knew was busy, gitcoiners were able to help me make my deadline, with fast, affordable, & high quality work."),
'https://github.com/jschiarizzi', 'Fourth Wave'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E128 continuation line under-indented for visual indent

@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #1611 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1611   +/-   ##
======================================
  Coverage    29.9%   29.9%           
======================================
  Files         130     130           
  Lines        9648    9648           
  Branches     1245    1245           
======================================
  Hits         2885    2885           
  Misses       6659    6659           
  Partials      104     104
Impacted Files Coverage Δ
app/retail/views.py 37.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9da39...5249461. Read the comment docs.

@@ -50,6 +50,9 @@ def index(request):
("Piper", static("v2/images/testimonials/pipermerriam.jpg"),
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."),
'https://github.com/pipermerriam', 'Pipermerriam'),
("Joseph Schiarizzi", static("v2/images/testimonials/jschiarizzi.jpeg"),
_("On a Friday I needed a front end done for a project due in 48 hours. When everyone I knew was busy, gitcoiners were able to help me make my deadline, with fast, affordable, & high quality work."),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (209 > 120 characters)

@ghost ghost assigned SaptakS Jul 4, 2018
@ghost ghost added the in progress label Jul 4, 2018
@SaptakS SaptakS merged commit ed23b13 into gitcoinco:master Jul 4, 2018
@ghost ghost removed the in progress label Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants