Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: set title attribute to null when switching to right network #1633

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

thelostone-mc
Copy link
Member

Description

The tooltip persists when you switch from the wrong network to the right network.
This PR fixes that

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines

@ghost ghost assigned thelostone-mc Jul 5, 2018
@ghost ghost added the in progress label Jul 5, 2018
@thelostone-mc thelostone-mc changed the title bug: set title attribute to null when connected to right network bug: set title attribute to null when switching to right network Jul 5, 2018
@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #1633 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   29.69%   29.69%           
=======================================
  Files         132      132           
  Lines        9784     9784           
  Branches     1270     1270           
=======================================
  Hits         2905     2905           
  Misses       6773     6773           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed1d80...b9d8f86. Read the comment docs.

@thelostone-mc thelostone-mc merged commit ce14071 into gitcoinco:master Jul 6, 2018
@ghost ghost removed the in progress label Jul 6, 2018
@thelostone-mc thelostone-mc deleted the fixes branch July 6, 2018 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants