Implement management command 'sync_listener' #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It listens for new blocks that contain transactions to standard bounties(fulfillBounty), and processes those bounties instantly. Example: ./manage.py sync_listener mainnet Fixes 1605
stickler-ci
reviewed
Jul 7, 2018
| logging.getLogger("requests").setLevel(logging.WARNING) | ||
| logging.getLogger("urllib3").setLevel(logging.WARNING) | ||
|
|
||
| def process_bounty(bounty_id, network): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
| bounty = get_bounty(bounty_id, network) | ||
| web3_process_bounty(bounty) | ||
|
|
||
| class Command(BaseCommand): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
- Coverage 29.49% 29.37% -0.13%
==========================================
Files 132 133 +1
Lines 9870 9911 +41
Branches 1285 1289 +4
==========================================
Hits 2911 2911
- Misses 6854 6895 +41
Partials 105 105
Continue to review full report at Codecov.
|
added 2 commits
July 7, 2018 21:15
Style fixes
Continue the txs loop if getTransaction returns None Style fixes.
|
i dont think this is working
|
ghost
assigned
stickler-ci
reviewed
Jul 9, 2018
|
|
||
| print('found a stdbounties tx') | ||
| data = tx['input'] | ||
| method_id = data[:10] |
There was a problem hiding this comment.
F841 local variable 'method_id' is assigned to but never used
| print('found a stdbounties tx') | ||
| data = tx['input'] | ||
| method_id = data[:10] | ||
| #if method_id != '0x1e688c14': |
There was a problem hiding this comment.
E265 block comment should start with '# '
owocki
reviewed
Jul 9, 2018
| print('found a stdbounties tx') | ||
| data = tx['input'] | ||
| method_id = data[:10] | ||
| #if method_id != '0x1e688c14': |
There was a problem hiding this comment.
can this work with every other method in stdbounties too?
|
f328c2a enables all methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It listens for new blocks that contain transactions to standard bounties(fulfillBounty), and processes those bounties instantly.
Example:
./manage.py sync_listener mainnet
Fixes #1605