-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Just 1 Alert Banner for ERC20 Token #1668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
======================================
Coverage 25.5% 25.5%
======================================
Files 130 130
Lines 10686 10686
Branches 1425 1425
======================================
Hits 2725 2725
Misses 7883 7883
Partials 78 78 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the alert to a warning if it's an error?
app/assets/v2/js/shared.js
Outdated
if (!document.alert_enable_token_shown) { | ||
_alert("You have not yet enabled this token. To enable this token, go to the <a style='padding-left:5px;' href='/settings/tokens'> Token Settings page and enable it</a>. (this is only needed one time per token)"); | ||
} | ||
document.alert_enable_token_shown = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be a warning alert like here
Ahh, will rebase ;) |
@pinkiebell Oh I meant , just make it a warning alert by default but this could work too ! Could you squash the commits into one neat commit ? |
@thelostone-mc Let me know if you want me to revert back to just the warning message. |
Let's just stick to warning for now and do away with displaying the error message 👍 |
@thelostone-mc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Merging
Fixes #1566