-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable bounty hunters #1682 #1688
Clickable bounty hunters #1682 #1688
Conversation
Good for review ? |
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
==========================================
+ Coverage 29.15% 29.16% +<.01%
==========================================
Files 134 134
Lines 10062 10065 +3
Branches 1319 1319
==========================================
+ Hits 2934 2935 +1
- Misses 7023 7025 +2
Partials 105 105
Continue to review full report at Codecov.
|
@thelostone-mc Need to clarify what @owocki wants to happen when you click the avatars. |
one piece of feedback: can we make hte distance between these two lines less? http://bits.owocki.com/0e2g3P1r0J0w/Screen%20Shot%202018-07-11%20at%2010.25.32%20AM.png responsiveness looks good. maybe when you click, we can just add a slight color mask (#111 instead of #000? ) until you release your click? |
@owocki That seems confusing in my head! Wouldn't users end up waiting longer to see something happen 🤔 |
ok im not married to the clickability idea if you guys dont think its a good idea |
How should we proceed here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, changes look good to me. To reiterate what @thelostone-mc said... we should delete assets that are replaced and update references the new assets as appropriate.
Thanks for squashing the SVGs!
@olafghanizadeh just leave them as non clickable :P |
refs: #1682
Make bounty hunters clickable
Test for responsiveness
Switch assets to SVG and text instead of image
Recreate HTML with bootstrap