3d dataviz of gas prices vs confirmation time #1749

owocki · 2018-07-15T05:43:58Z

could be cool to put on the gas station, not sure how its gonna perform marketing-wise tho

stickler-ci · 2018-07-15T05:44:17Z

app/gas/management/commands/output_gas_viz.py

+import os
+from gas.models import GasProfile
+import matplotlib
+import random


F401 'random' imported but unused

stickler-ci · 2018-07-15T05:44:18Z

app/gas/management/commands/output_gas_viz.py

+import matplotlib
+import random
+matplotlib.use('Agg')
+from numpy  import array


E402 module level import not at top of file
E272 multiple spaces before keyword

stickler-ci · 2018-07-15T05:44:18Z

app/gas/management/commands/output_gas_viz.py

+import random
+matplotlib.use('Agg')
+from numpy  import array
+from mpl_toolkits.mplot3d import axes3d


E402 module level import not at top of file
F401 'mpl_toolkits.mplot3d.axes3d' imported but unused

stickler-ci · 2018-07-15T05:44:18Z

app/gas/management/commands/output_gas_viz.py

+matplotlib.use('Agg')
+from numpy  import array
+from mpl_toolkits.mplot3d import axes3d
+import matplotlib.pyplot as plt


E402 module level import not at top of file

stickler-ci · 2018-07-15T05:44:18Z

app/gas/management/commands/output_gas_viz.py

+from numpy  import array
+from mpl_toolkits.mplot3d import axes3d
+import matplotlib.pyplot as plt
+from matplotlib import cm


E402 module level import not at top of file
F401 'matplotlib.cm' imported but unused

stickler-ci · 2018-07-15T05:44:19Z

app/gas/management/commands/output_gas_viz.py

+            package[key].append(new_pkg)
+
+        clear_cache()
+        #install_ffmpeg()


E265 block comment should start with '# '

stickler-ci · 2018-07-15T05:44:19Z

app/gas/management/commands/output_gas_viz.py

+        num_items_to_show_at_a_time = 50
+        for j in range(num_items_to_show_at_a_time, len(arr)):
+            print(j)
+            key = f"Ethereum Mainnet Gas Tradeoffs\n Gas Prices (x axis) vs Time to Confirm (y axis) vs Time (z axis) \n {keys[j]}"


E501 line too long (131 > 120 characters)

stickler-ci · 2018-07-15T05:44:19Z

app/gas/management/commands/output_gas_viz.py

+            if invert_colors:
+                axiscolor = 'white'
+                ax.spines['bottom'].set_color(axiscolor)
+                ax.spines['top'].set_color(axiscolor) 


W291 trailing whitespace

stickler-ci · 2018-07-15T05:44:19Z

app/gas/management/commands/output_gas_viz.py

+            ax.set_zlabel('Time To Confirm (min)')
+
+
+            X = []


E303 too many blank lines (2)

stickler-ci · 2018-07-15T05:44:20Z

app/gas/management/commands/output_gas_viz.py

+                Y = tmp[1]
+                Z = tmp[2]
+                color = get_color(j, k, num_items_to_show_at_a_time)
+                ax.plot_wireframe(array(X), array(Y), array(Z), rstride=10, cstride=10, color=color, alpha=1-(k/num_items_to_show_at_a_time))


E501 line too long (141 > 120 characters)

codecov · 2018-07-15T05:54:04Z

Codecov Report

Merging #1749 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   29.16%   28.84%   -0.32%     
==========================================
  Files         127      128       +1     
  Lines        9956    10066     +110     
  Branches     1316     1328      +12     
==========================================
  Hits         2904     2904              
- Misses       6945     7055     +110     
  Partials      107      107

Impacted Files	Coverage Δ
app/dashboard/gas_views.py	`33.96% <ø> (ø)`	⬆️
app/gas/management/commands/output_gas_viz.py	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed26fd...863cf1c. Read the comment docs.

stickler-ci · 2018-07-15T05:54:21Z

app/gas/management/commands/output_gas_viz.py

@@ -0,0 +1,142 @@
+import datetime
+import os
+import random


F401 'random' imported but unused

stickler-ci · 2018-07-15T05:54:21Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


E501 line too long (123 > 120 characters)

Thoughts on using an ffmpeg wrapper for this like moviepy or something similar?

either way seems acceptable to me.

stickler-ci · 2018-07-15T05:54:21Z

app/gas/management/commands/output_gas_viz.py

+        import matplotlib
+        matplotlib.use('Agg')
+        import matplotlib.pyplot as plt
+        from mpl_toolkits.mplot3d import axes3d


F401 'mpl_toolkits.mplot3d.axes3d' imported but unused

SaptakS · 2018-07-15T06:29:29Z

@owocki this looks cool. So if I understand correctly, this rotates on mousedrag in 3d space??

SaptakS · 2018-07-15T06:29:46Z

Sorry. My mistake.

mbeacom · 2018-07-15T08:07:24Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


Thoughts on using an ffmpeg wrapper for this like moviepy or something similar?

mbeacom · 2018-07-15T08:07:54Z

app/gas/management/commands/output_gas_viz.py

+def install_ffmpeg():
+    command = 'apt update -y '
+    os.system(command)
+    command = 'apt install ffmpeg libav-tools x264 x265 -y'


Can we add ffmpeg libav-tools x264 x265 to the dockerfile build steps?

mbeacom · 2018-07-15T08:10:48Z

app/gas/management/commands/output_gas_viz.py

+                z_angle = 10
+            ax.view_init(z_angle, degrees)
+
+            png_file = 'cache/frames/{}.jpg'.format(str(j).rjust(10, '0'))


Can we update this to use an f-string?

mbeacom · 2018-07-15T08:11:00Z

app/retail/templates/gas.html

+  <br>
+  <video width="640" height="480" controls>
+  <source src="/static/tmp/gas_price_viz.mp4" type="video/mp4">
+Your browser does not support the video tag.


Should we wrap this in {% trans "" %} ?

mbeacom · 2018-07-15T08:11:36Z

app/retail/templates/gas.html

+      .on('mouseover', function(d) {
+        var tooltip_msg = '<div>';
+        tooltip_msg = `Gas Price: ${d.gas_price}`;
+        tooltip_msg = tooltip_msg + `<br/>Confirmation time: ${d.confirmation_time} min`;


Should we wrap the copy throughout in trans ?

stickler-ci · 2018-07-15T13:56:58Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


E501 line too long (123 > 120 characters)

stickler-ci · 2018-07-15T13:56:58Z

app/gas/management/commands/output_gas_viz.py

+        invert_colors = False
+        max_gas = 50
+        package = {}
+        for gp in GasProfile.objects.filter(gas_price__lt=max_gas, created_on__gt=timezone.now() - timezone.timedelta(days=7)).order_by('created_on'):


E501 line too long (150 > 120 characters)

stickler-ci · 2018-07-15T13:56:58Z

app/gas/management/commands/output_gas_viz.py

+        num_items_to_show_at_a_time = 50
+        for j in range(num_items_to_show_at_a_time, len(arr)):
+            print(j)
+            key = f"Ethereum Mainnet Gas Tradeoffs\n Gas Prices (x axis) vs Time to Confirm (y axis) vs Time (z axis) \n {keys[j]}\n\nMade with <3 at Gitcoin.\nhttps://gitcoin..co/gas"


E501 line too long (184 > 120 characters)

stickler-ci · 2018-07-15T17:13:54Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


E501 line too long (123 > 120 characters)

owocki · 2018-07-15T17:14:20Z

updated per code review

stickler-ci · 2018-07-15T17:14:52Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


E501 line too long (123 > 120 characters)

stickler-ci · 2018-07-15T17:28:57Z

app/gas/management/commands/output_gas_viz.py

+
+
+def convert_to_movie():
+    command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"


E501 line too long (123 > 120 characters)

owocki · 2018-07-15T18:24:12Z

linter/tests are passing locally.. hmm

3d dataviz of gas prices vs confirmation time

8986d76

ghost assigned owocki Jul 15, 2018

ghost added the in progress label Jul 15, 2018

stickler-ci reviewed Jul 15, 2018

View reviewed changes

linter

1fe6318

stickler-ci reviewed Jul 15, 2018

View reviewed changes

SaptakS closed this Jul 15, 2018

ghost removed the in progress label Jul 15, 2018

SaptakS reopened this Jul 15, 2018

ghost assigned SaptakS Jul 15, 2018

ghost added the in progress label Jul 15, 2018

mbeacom reviewed Jul 15, 2018

View reviewed changes

sunday funday

ff5368b

stickler-ci reviewed Jul 15, 2018

View reviewed changes

code review

56d318a

stickler-ci reviewed Jul 15, 2018

View reviewed changes

small changes

03e30af

stickler-ci reviewed Jul 15, 2018

View reviewed changes

gas page template

863cf1c

stickler-ci reviewed Jul 15, 2018

View reviewed changes

owocki merged commit 4e07d96 into master Jul 15, 2018

ghost removed the in progress label Jul 15, 2018

thelostone-mc deleted the kevin/dataviz3 branch December 28, 2018 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3d dataviz of gas prices vs confirmation time #1749

3d dataviz of gas prices vs confirmation time #1749

owocki commented Jul 15, 2018 •

edited

Loading

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

codecov bot commented Jul 15, 2018 •

edited

Loading

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

mbeacom Jul 15, 2018

owocki Jul 15, 2018

stickler-ci Jul 15, 2018

SaptakS commented Jul 15, 2018 •

edited

Loading

SaptakS commented Jul 15, 2018

mbeacom Jul 15, 2018

mbeacom Jul 15, 2018

owocki Jul 15, 2018

mbeacom Jul 15, 2018

owocki Jul 15, 2018

mbeacom Jul 15, 2018

mbeacom Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

owocki commented Jul 15, 2018

stickler-ci Jul 15, 2018

stickler-ci Jul 15, 2018

owocki commented Jul 15, 2018



		def convert_to_movie():
		command = "ffmpeg -framerate 30 -pattern_type glob -i 'cache/frames/*.jpg' -c:v libx264 -pix_fmt yuv420p cache/out.mp4"

3d dataviz of gas prices vs confirmation time #1749

3d dataviz of gas prices vs confirmation time #1749

Conversation

owocki commented Jul 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 15, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SaptakS commented Jul 15, 2018 • edited Loading

SaptakS commented Jul 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jul 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jul 15, 2018

owocki commented Jul 15, 2018 •

edited

Loading

codecov bot commented Jul 15, 2018 •

edited

Loading

SaptakS commented Jul 15, 2018 •

edited

Loading