[WIP] UI Inventory #1755

pinkiebell · 2018-07-15T17:02:55Z

stickler-ci · 2018-07-15T17:03:16Z

app/retail/views.py

@@ -939,3 +939,11 @@ def tokens(request):
        key = f"{network}_tokens"
        context[key] = Token.objects.filter(network=network, approved=True)
    return TemplateResponse(request, 'tokens_js.txt', context, content_type='text/javascript')
+
+def ui(request):


E302 expected 2 blank lines, found 1

owocki · 2018-07-16T02:11:51Z

let me know when this isnt WIP anymore and ill review

codecov · 2018-07-16T04:27:16Z

Codecov Report

Merging #1755 into master will decrease coverage by 0.04%.
The diff coverage is 10%.

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   28.58%   28.53%   -0.05%     
==========================================
  Files         128      128              
  Lines       10066    10089      +23     
  Branches     1328     1334       +6     
==========================================
+ Hits         2877     2879       +2     
- Misses       7088     7109      +21     
  Partials      101      101

Impacted Files	Coverage Δ
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/retail/views.py	`29.48% <10%> (-1.83%)`	⬇️
app/retail/utils.py	`14.9% <0%> (-0.22%)`	⬇️
app/dashboard/helpers.py	`17.56% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9731c...bf4447c. Read the comment docs.

stickler-ci · 2018-07-16T04:27:38Z

app/assets/v2/js/pages/tabs.js

+  var last = null;
+
+  while (buttons !== null) {
+    function onClick(evt) {


Move function declaration to function body root. (no-inner-declarations)
Don't make functions within a loop. (no-loop-func)

stickler-ci · 2018-07-16T04:27:38Z

app/assets/v2/js/pages/tabs.js

+  while (buttons !== null) {
+    function onClick(evt) {
+      var width = evt.target.offsetWidth;
+      var offset = evt.target.offsetLeft;


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-07-16T04:27:38Z

app/assets/v2/js/pages/tabs.js

+      indicator.style.width = width + 'px';
+      indicator.style.transform = 'translateX(' + offset + 'px)';
+
+      var current = sections.querySelector('#' + evt.target.id);


Expected blank line after variable declarations. (newline-after-var)

pinkiebell · 2018-07-16T04:45:46Z

@owocki Ready for review.
If I forgot a UI element, let me know.

SaptakS · 2018-07-16T12:42:00Z

app/app/urls.py

@@ -178,6 +178,7 @@
    # brochureware views
    url(r'^about/?', retail.views.about, name='about'),
    url(r'^mission/?', retail.views.mission, name='mission'),
+    url(r'^ui/?', retail.views.ui, name='ui'),


Please use re_path since we are trying to migrate completely from url

mbeacom

In addition to the requested changes, can you please include an addition to the CONTRIBUTING.md document explaining any addition of visual assets should be included in the inventory?

mbeacom · 2018-07-16T16:13:24Z

app/retail/templates/ui_inventory.html

+{% endcomment %}
+{% load i18n static %}
+<!DOCTYPE html>
+<html lang="en">


Can you wrap relevant copy with {% trans "" %} ?

mbeacom · 2018-07-16T16:14:15Z

app/app/urls.py

@@ -178,6 +178,7 @@
    # brochureware views
    url(r'^about/?', retail.views.about, name='about'),
    url(r'^mission/?', retail.views.mission, name='mission'),
+    url(r'^ui/?', retail.views.ui, name='ui'),


thelostone-mc · 2018-07-18T11:15:51Z

@PixelantDesign @mbeacom @SaptakS

This is the how the page looks at the moment

pinkiebell · 2018-07-18T12:24:54Z

@thelostone-mc
The two robo-heads in the animation section and the content in the carousel section is missing in the screenshot.

thelostone-mc · 2018-07-18T15:07:10Z

@pinkiebell lol thats cause I took a full page screenshot and the animation kicks in only when you actually scroll :P

Btw just synced up with @PixelantDesign

Could you tick whatever you've covered on the checklist (mentioned in the issue)
Also could you throw in the code snippet below each component so that folks know how to use it
(don't worry about how it looks, we'll fix it up in iterative-ly )
resolve conflicts by rebasing with master

pinkiebell · 2018-07-18T17:25:41Z

@thelostone-mc

Can you checkout the new changes?
I did a rebase, and included the modal dialog and you can now click on the examples on the page to open a modal dialog with the 'showdown'-converted html source 👍 .

thelostone-mc · 2018-07-19T16:44:36Z

@pinkiebell wohoo ^_^

@PixelantDesign Merge ready ?
@pinkiebell has checked out whatever she's added in the list

@SaptakS / @mbeacom If in case you guys merge it before I get to it -> we need to change to uri to /styleguide-alpha so that it's hard to find :P (As advised by @PixelantDesign )

thelostone-mc

LGTM

SaptakS · 2018-07-20T07:24:25Z

I am just curious if giving an icons like here to show the code is more intuitive than clicking on the card.

Fixes #1755

Improve the code viewer and give the user a hint.

pinkiebell · 2018-07-21T02:04:31Z

Just a quick rebase and I added some more assets + style fixes.
@SaptakS
Isn't it a bit too much If we show a icon on every example?

PS: changed path to /styleguide-alpha

PixelantDesign · 2018-07-21T02:47:22Z

Looks good thank you @pinkiebell

mbeacom · 2018-07-21T15:57:35Z

app/retail/templates/ui_inventory.html

+
+      <div class="container-fluid p-5 assets">
+        <p class="h1">{% trans "Vector Graphics" %}</p>
+        <img src="{% static "v2/images/quickstart-box.svg" %}"/>


I am not saying we need to do it here... but we'll probably want to modify the vast majority of the asset handling and repetitive entries here to simply loop over assets in images/ and the associated subs / context data. We'd drop the line count in this file down by quite a bit and we wouldn't have to manually add every new asset as they're added (I'd be willing to bet it won't be long until we're missing assets here).

That would be very nice. I'm not familiar with Django, so I will dig into that today. 👍

thelostone-mc · 2018-07-23T09:45:07Z

@SaptakS meh it's just for a first pass -> we'll improve it in cycles
I guess the scope of this task was just to get all the components together on one page

I already bugged @pinkiebell to add the code snippets (even though I believe it wasn't part of the original task :P )

thelostone-mc

LGTM !

Fixes gitcoinco#1755

stickler-ci reviewed Jul 15, 2018

View reviewed changes

stickler-ci reviewed Jul 16, 2018

View reviewed changes

pinkiebell changed the title ~~WIP: UI Inventory~~ UI Inventory Jul 16, 2018

SaptakS reviewed Jul 16, 2018

View reviewed changes

mbeacom reviewed Jul 16, 2018

View reviewed changes

mbeacom changed the title ~~UI Inventory~~ [WOC] UI Inventory Jul 16, 2018

mbeacom added frontend This needs frontend expertise. waiting on contributor and removed waiting on contributor labels Jul 16, 2018

mbeacom changed the title ~~[WOC] UI Inventory~~ UI Inventory Jul 16, 2018

pinkiebell mentioned this pull request Jul 18, 2018

Inventory Current Gitcoin UI Styles #1738

Closed

22 tasks

thelostone-mc previously approved these changes Jul 19, 2018

View reviewed changes

pinkiebell added 3 commits July 21, 2018 03:58

UI Inventory

266f4a6

Fixes #1755

UI Inventory

4d5c6a6

Improve the code viewer and give the user a hint.

UI Inventory; a few more assets and style fixes

93decb5

pinkiebell dismissed thelostone-mc’s stale review via 93decb5 July 21, 2018 01:58

mbeacom reviewed Jul 21, 2018

View reviewed changes

mbeacom changed the title ~~UI Inventory~~ [WIP] UI Inventory Jul 21, 2018

mbeacom added the wip label Jul 21, 2018

UI Inventory: Make use of django for static assets.

2f74623

thelostone-mc previously approved these changes Jul 30, 2018

View reviewed changes

doc: updated styleguide uri

bf4447c

thelostone-mc dismissed their stale review via bf4447c July 30, 2018 13:49

thelostone-mc approved these changes Jul 30, 2018

View reviewed changes

thelostone-mc merged commit 8b2db5b into gitcoinco:master Jul 30, 2018

pinkiebell deleted the inventory branch November 6, 2018 08:44

jvmaia pushed a commit to jvmaia/web that referenced this pull request Nov 12, 2018

UI Inventory

aad7e66

Fixes gitcoinco#1755

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] UI Inventory #1755

[WIP] UI Inventory #1755

pinkiebell commented Jul 15, 2018 •

edited

Loading

stickler-ci Jul 15, 2018

owocki commented Jul 16, 2018

codecov bot commented Jul 16, 2018 •

edited

Loading

stickler-ci Jul 16, 2018

stickler-ci Jul 16, 2018

stickler-ci Jul 16, 2018

pinkiebell commented Jul 16, 2018

SaptakS Jul 16, 2018

mbeacom Jul 16, 2018

mbeacom left a comment

mbeacom Jul 16, 2018

mbeacom Jul 16, 2018

thelostone-mc commented Jul 18, 2018

pinkiebell commented Jul 18, 2018

thelostone-mc commented Jul 18, 2018 •

edited

Loading

pinkiebell commented Jul 18, 2018 •

edited

Loading

thelostone-mc commented Jul 19, 2018 •

edited

Loading

thelostone-mc left a comment

SaptakS commented Jul 20, 2018

pinkiebell commented Jul 21, 2018 •

edited

Loading

PixelantDesign commented Jul 21, 2018

mbeacom Jul 21, 2018

pinkiebell Jul 21, 2018

thelostone-mc commented Jul 23, 2018

thelostone-mc left a comment

[WIP] UI Inventory #1755

[WIP] UI Inventory #1755

Conversation

pinkiebell commented Jul 15, 2018 • edited Loading

Choose a reason for hiding this comment

owocki commented Jul 16, 2018

codecov bot commented Jul 16, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pinkiebell commented Jul 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc commented Jul 18, 2018

pinkiebell commented Jul 18, 2018

thelostone-mc commented Jul 18, 2018 • edited Loading

pinkiebell commented Jul 18, 2018 • edited Loading

thelostone-mc commented Jul 19, 2018 • edited Loading

thelostone-mc left a comment

Choose a reason for hiding this comment

SaptakS commented Jul 20, 2018

pinkiebell commented Jul 21, 2018 • edited Loading

PixelantDesign commented Jul 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc commented Jul 23, 2018

thelostone-mc left a comment

Choose a reason for hiding this comment

pinkiebell commented Jul 15, 2018 •

edited

Loading

codecov bot commented Jul 16, 2018 •

edited

Loading

thelostone-mc commented Jul 18, 2018 •

edited

Loading

pinkiebell commented Jul 18, 2018 •

edited

Loading

thelostone-mc commented Jul 19, 2018 •

edited

Loading

pinkiebell commented Jul 21, 2018 •

edited

Loading