-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidated payment wizard flow #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
+ Coverage 28.59% 30.68% +2.09%
==========================================
Files 128 130 +2
Lines 10047 11441 +1394
Branches 1324 1678 +354
==========================================
+ Hits 2873 3511 +638
- Misses 7073 7780 +707
- Partials 101 150 +49
Continue to review full report at Codecov.
|
very cool |
This is neattttt! Good for review ? |
Just a question. Are we adding this color to our pallette of colors. Since I saw you using this also in the admin actions PR so curious. @PixelantDesign .I was wondering if we could stick to one of our blues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment, lgtm. - Should we throw this on staging to start QA?
app/dashboard/models.py
Outdated
@@ -938,7 +938,7 @@ def receive_url(self): | |||
if self.web3_type == 'yge': | |||
return self.url | |||
|
|||
pk = self.metadata['priv_key'] | |||
pk = self.metadata.get('priv_key') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we default to something in this get
or should we use pk = self.metadata['priv_key']
wrapped in try/except on KeyError
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change actually shouldnt get in this PR. ill remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@SaptakS its probably a better idea to stick to one of the palette colors. ill give the blue a try unless @PixelantDesign has another direction she wants to go |
just turned around the feedback |
This PR has a vastly improved payout flow, in my opinioin.
UX:
Check it out: http://bits.owocki.com/0P0q3R3d1B38/Screen%20Recording%202018-07-18%20at%2010.54%20PM.gif