Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructuted profiles #1800

Merged
merged 2 commits into from
Jul 20, 2018
Merged

restructuted profiles #1800

merged 2 commits into from
Jul 20, 2018

Conversation

thelostone-mc
Copy link
Member

Description
  • Indent + Restructure
  • All profile templates resides within profile/ & have been broken down into smaller templates
    to make code more maintainable

This is not being pushed to the orgs branch as I wanna avoid dealing with conflicts due to this restructuring. All further changes will be made in the mark-orgs branch

Refers

@ghost ghost assigned thelostone-mc Jul 20, 2018
@ghost ghost added the in progress label Jul 20, 2018
@mbeacom
Copy link
Contributor

mbeacom commented Jul 20, 2018

@thelostone-mc Good call. Reviewing now!

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #1800 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   28.58%   28.58%           
=======================================
  Files         128      128           
  Lines       10056    10056           
  Branches     1328     1328           
=======================================
  Hits         2875     2875           
  Misses       7080     7080           
  Partials      101      101
Impacted Files Coverage Δ
app/dashboard/views.py 15.23% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ed566...33f6f95. Read the comment docs.

@ghost ghost assigned mbeacom Jul 20, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tested locally and on staging. 👍

@mbeacom mbeacom merged commit 008f351 into gitcoinco:master Jul 20, 2018
@ghost ghost removed the in progress label Jul 20, 2018
@thelostone-mc thelostone-mc deleted the profile branch July 20, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants