Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css: minor refactor #1862

Merged
merged 1 commit into from
Jul 31, 2018
Merged

css: minor refactor #1862

merged 1 commit into from
Jul 31, 2018

Conversation

thelostone-mc
Copy link
Member

Description
  • trans support
  • a bit of css refactor
  • Cause we serve the dark lord @mbeacom

@thelostone-mc thelostone-mc mentioned this pull request Jul 31, 2018
Merged
3 tasks
@codecov
Copy link

codecov bot commented Jul 31, 2018 •
edited
Loading

Codecov Report

Merging #1862 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1862   +/-   ##
======================================
  Coverage    25.6%   25.6%           
======================================
  Files         129     129           
  Lines       10471   10471           
  Branches     1395    1395           
======================================
  Hits         2681    2681           
  Misses       7713    7713           
  Partials       77      77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5bce...4fdaa99. Read the comment docs.

SaptakS
SaptakS reviewed Jul 31, 2018
View reviewed changes
app/dashboard/templates/submit_bounty.html
@@ -53,9 +53,9 @@ <h5 class="font-subheader">{% trans "About" %}</h5>
<label class="form__label" for=issueURL>{% trans "Github Issue URL" %}</label>
<input name='issueURL' id="issueURL" class="form__input" type="url" placeholder="https://github.com/user/repo/issues/n" value="{% if issueURL %}{{issueURL}}{%endif%}" />
<label class="form__label" for="title">{% trans "Github Issue Title" %}</label>
<input name='title' id="title" class="form__input" type="text" placeholder="Deploy the Foo to The Bar" value="{{issue_title}}" title="Please update the title in the github issue" readonly/>
<input name='title' id="title" class="form__input" type="text" placeholder="Deploy the Foo to The Bar" value="{{issue_title}}" title="<div class='tooltip-info tooltip-sm'>{% trans "Please update the title in the github issue" %}</div>" readonly/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free lunch? :D

SaptakS
SaptakS approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SaptakS SaptakS merged commit 2c5df01 into gitcoinco:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptakS SaptakS SaptakS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @SaptakS @mbeacom