Switching tree section on landing page #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 130 130
Lines 10684 10684
Branches 1425 1425
=======================================
Hits 2724 2724
Misses 7882 7882
Partials 78 78Continue to review full report at Codecov.
|
| @@ -46,20 +46,11 @@ | |||
| {% include 'landing/funder/benefits.html' %} | |||
| </div> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
could we remove the extra line ?
| <div class='col-lg-8 col-lg-offset-2'> | ||
| <hr> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Why do we have this extra row ? Could we remove it ?
|
@thelostone-mc changes made as suggested |
app/assets/v2/js/landing_page.js
Outdated
|
|
||
| if(scrollContainer.scrollTop() > treeAnimationPosition) { |
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
|
@nanspro I added a few more changes on top of it ^_^ |
|
Hey @nanspro first off thanks for turning this around quick ^_^ Could you shoot up another PR once @PixelantDesign gives you the icons? Thanks for contributing and welcome to gitcoin :D |
Description
Switching tree section with 1,2,3 section on landing page.
Checklist
Affected core subsystem(s)
frontend
Testing
Locally
Refers
Fixes #1861