-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching tree section on landing page #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 130 130
Lines 10684 10684
Branches 1425 1425
=======================================
Hits 2724 2724
Misses 7882 7882
Partials 78 78 Continue to review full report at Codecov.
|
@@ -46,20 +46,11 @@ | |||
{% include 'landing/funder/benefits.html' %} | |||
</div> | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove the extra line ?
<div class='col-lg-8 col-lg-offset-2'> | ||
<hr> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this extra row ? Could we remove it ?
@thelostone-mc changes made as suggested |
app/assets/v2/js/landing_page.js
Outdated
|
||
if(scrollContainer.scrollTop() > treeAnimationPosition) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected space(s) after "if". (keyword-spacing)
@nanspro I added a few more changes on top of it ^_^ |
Hey @nanspro first off thanks for turning this around quick ^_^ Could you shoot up another PR once @PixelantDesign gives you the icons? Thanks for contributing and welcome to gitcoin :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Switching tree section with 1,2,3 section on landing page.
Checklist
Affected core subsystem(s)
frontend
Testing
Locally
Refers
Fixes #1861