Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lander video switcharooooooooooooO #1927

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Aug 2, 2018

Description

puts the 'what is it' video on about, and adds the funder video the existing lander

screenshot => http://bits.owocki.com/0A2x1y3Z2W2b/Screen%20Shot%202018-08-02%20at%201.56.38%20PM.png

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

ui

Testing

tested

Refers/Fixes

#1836

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #1927 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1927      +/-   ##
==========================================
+ Coverage   25.49%   25.52%   +0.02%     
==========================================
  Files         130      130              
  Lines       10684    10669      -15     
  Branches     1425     1420       -5     
==========================================
- Hits         2724     2723       -1     
+ Misses       7882     7868      -14     
  Partials       78       78
Impacted Files Coverage Δ
app/git/utils.py 47.15% <0%> (+0.14%) ⬆️
app/retail/utils.py 14.69% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105cb6d...788f3cf. Read the comment docs.

mbeacom
mbeacom previously approved these changes Aug 2, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit: 🚢

@owocki
Copy link
Contributor Author

owocki commented Aug 2, 2018

@PixelantDesign any feedback?

@thelostone-mc
Copy link
Member

thelostone-mc commented Aug 3, 2018

Updating the design just a bit

screen shot 2018-08-03 at 5 10 11 pm

@owocki could you tag me / @SaptakS in the UI changes too ? Would help us SHIPL faster :P

thelostone-mc
thelostone-mc previously approved these changes Aug 3, 2018
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc dismissed stale reviews from mbeacom and themself via 788f3cf August 3, 2018 14:52
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thelostone-mc thelostone-mc merged commit cbb7c66 into master Aug 3, 2018
@thelostone-mc thelostone-mc deleted the kevin/lander_video branch August 3, 2018 14:53
@owocki
Copy link
Contributor Author

owocki commented Aug 6, 2018

@thelostone-mc whats the idea behind putting the 'mission' and 'not a token' buttons next to each other?

the 'mission' button is meant to go with the h3 'A Mission to Grow Open Source.'
same with the 'not a token' one. its meant to go below the h3 'No ICO. No Token. No Funny Business.'

@thelostone-mc
Copy link
Member

Would you like it be place like that ?
I know this seems a lil unorthodox but it seemed clear to me
Mission (you see the button below it)
The button next to it would be defaulted to the content below it

We can switch it back if you found it misleading

@PixelantDesign
Copy link
Contributor

@thelostone-mc treatment of the buttons look nice visually but from a flow/ content and connection perspective, it would read better/make more sense per @owocki recommendation.

@thelostone-mc
Copy link
Member

Okie me switching it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants