-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lander video switcharooooooooooooO #1927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
==========================================
+ Coverage 25.49% 25.52% +0.02%
==========================================
Files 130 130
Lines 10684 10669 -15
Branches 1425 1420 -5
==========================================
- Hits 2724 2723 -1
+ Misses 7882 7868 -14
Partials 78 78
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚢
@PixelantDesign any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0fcc883
to
788f3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@thelostone-mc whats the idea behind putting the 'mission' and 'not a token' buttons next to each other? the 'mission' button is meant to go with the h3 'A Mission to Grow Open Source.' |
Would you like it be place like that ? We can switch it back if you found it misleading |
@thelostone-mc treatment of the buttons look nice visually but from a flow/ content and connection perspective, it would read better/make more sense per @owocki recommendation. |
Okie me switching it back |
Description
puts the 'what is it' video on about, and adds the funder video the existing lander
screenshot => http://bits.owocki.com/0A2x1y3Z2W2b/Screen%20Shot%202018-08-02%20at%201.56.38%20PM.png
Checklist
Affected core subsystem(s)
ui
Testing
tested
Refers/Fixes
#1836