Change Bounty Details #1968

pinkiebell · 2018-08-08T21:27:54Z

bounty details ('experience_level', 'project_length', 'bounty_type',
'permission_type', 'project_type')

can be changed if the bounty is still on 'the happy path' by the funder
or staff.

Fixes #1928

stickler-ci · 2018-08-08T21:28:23Z

app/assets/v2/js/pages/change_bounty.js

@@ -0,0 +1,72 @@
+
+// Overwrite from shared.js
+function trigger_form_hooks() {


Unexpected empty function 'trigger_form_hooks'. (no-empty-function)

stickler-ci · 2018-08-08T21:28:23Z

app/assets/v2/js/pages/change_bounty.js

+
+// Overwrite from shared.js
+function trigger_form_hooks() {
+};


Unnecessary semicolon. (no-extra-semi)

stickler-ci · 2018-08-08T21:28:23Z

app/dashboard/views.py

+    """Change bounty."""
+
+
+    if request.body:


E303 too many blank lines (2)

codecov · 2018-08-08T21:37:13Z

Codecov Report

Merging #1968 into master will decrease coverage by 0.2%.
The diff coverage is 4.93%.

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   28.11%   27.91%   -0.21%     
==========================================
  Files         136      136              
  Lines       11025    11130     +105     
  Branches     1475     1499      +24     
==========================================
+ Hits         3100     3107       +7     
- Misses       7816     7913      +97     
- Partials      109      110       +1

Impacted Files	Coverage Δ
app/app/urls.py	`84.09% <ø> (ø)`	⬆️
app/dashboard/notifications.py	`16.76% <0%> (-0.33%)`	⬇️
app/dashboard/helpers.py	`17.2% <0%> (ø)`	⬆️
app/retail/emails.py	`20.18% <20%> (-0.01%)`	⬇️
app/dashboard/views.py	`14% <4.08%> (-0.74%)`	⬇️
app/marketing/mails.py	`11.52% <6.66%> (-0.17%)`	⬇️
app/app/settings.py	`78.57% <0%> (-4.77%)`	⬇️
app/dashboard/models.py	`50.23% <0%> (-0.16%)`	⬇️
.../management/commands/pending_start_work_actions.py	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64b504...537ac16. Read the comment docs.

pinkiebell · 2018-08-16T13:29:45Z

Any feedback on this one? 😄

owocki · 2018-08-17T17:01:35Z

it still says WIP in the PR title and theres a few TODOs in the diff. is this ready for review?

pinkiebell · 2018-08-17T17:15:02Z

Yes, it's WIP because of the comments in the PR. I asked for first review in the linked issue ;)

owocki · 2018-08-20T23:48:58Z

QA notes

doesnt seem like the user can edit any of the details around project type
why is the URL for 'change details' so long? example URL. is it to transfer data from view to view? if so, why not just add ?pk=<pk> to the view and load the appro info from the database?
i dont think we want to let the user edit their issue desc / title on this view... i'd rather point them to github.
submit button on this page doesnt seem to do anything.. nor does their seem to be any validation on the page..

happ y to QA more when the items in the definition of done on the spec are completed

owocki · 2018-08-20T23:49:28Z

app/assets/v2/js/pages/bounty_details.js

@@ -754,6 +754,8 @@ var do_actions = function(result) {
  const show_suspend_auto_approval = document.isStaff && result['permission_type'] == 'approval';
  const show_admin_methods = document.isStaff;
  const show_moderator_methods = document.isModerator;
+  const show_change_bounty = isBountyOwner(result);


or is_admin

owocki · 2018-08-20T23:50:09Z

app/dashboard/templates/bounty/change.html

+</head>
+
+<body class="interior submit_bounty" style="background-color: #FFFFFF;">
+  {% include 'shared/tag_manager_2.html' %}


why build a whole new form. why not just re-use the new_bounty form?

I take a look at the new changes and modify the template if necessary for easier reuse. 👍

owocki · 2018-08-20T23:50:50Z

app/dashboard/views.py

+                timezone.datetime.fromtimestamp(deadline),
+                timezone=UTC)
+
+        item = params.get('attached_job_description', '')


i wonder if we could use django forms for any of this repetitive code.... cc @mbeacom

owocki · 2018-08-20T23:51:19Z

app/retail/templates/emails/bounty_changed.html

+
+<h1>{% trans "Bounty Details Changed" %}</h1>
+<br>
+


should we list out the details that have changed.. ?

I don' think that would be needed! cause the funder would see it on the bounty page upon redirection

owocki · 2018-08-20T23:51:26Z

app/retail/templates/emails/bounty_changed.txt

@@ -0,0 +1,3 @@
+Bounty Details Changed
+


no data in this email

I included the bounty.txt template 😕

pinkiebell · 2018-08-21T02:13:40Z

@owocki

Thanks for review 👍

doesnt seem like the user can edit any of the details around project type

That's odd, seems to be a conflict with new changes on master since I worked on it.
Will fix.

why is the URL for 'change details' so long? example URL. is it to transfer data from view to view?
if so, why not just add ?pk= to the view and load the appro info from the database?

Yep, I transfer the bounty details with this method.
I will change it to use the pk= query parameter.

i dont think we want to let the user edit their issue desc / title on this view... i'd rather point them to github.

That I wasn't sure about. Will be removed.

submit button on this page doesnt seem to do anything.. nor does their seem to be any validation on the page..

The same problem like 1.

stickler-ci · 2018-08-21T18:38:52Z

app/dashboard/views.py

+    keys = ['experience_level', 'project_length', 'bounty_type', 'permission_type', 'project_type']
+
+    if request.body:
+        can_change = (bounty.status in Bounty.OPEN_STATUSES) or (bounty.can_submit_after_expiration_date and bounty.status is 'expired')


E501 line too long (136 > 120 characters)

pinkiebell · 2018-08-21T18:55:25Z

@owocki

Ready for review (again) 👍 .
The only open question is the additional content of the email templates; if wanted.

owocki · 2018-08-22T20:20:51Z

just tested... seems to work well 👍

thelostone-mc · 2018-08-24T06:59:59Z

@pinkiebell quick rebase and then we merge ?

bounty details ('experience_level', 'project_length', 'bounty_type', 'permission_type', 'project_type') can be changed if the bounty is still on 'the happy path' by the funder or staff. Fixes #1928

pinkiebell · 2018-08-24T10:53:42Z

@thelostone-mc Done! 👍

thelostone-mc

tested it out ! LGTM

thelostone-mc · 2018-08-24T21:06:31Z

@PixelantDesign this is how it looks

@pinkiebell Oh i just noticed should we update the placeholder text ?
Along the lines to -> Update your bounty settings to get the right crowd ? @vs77bb might have something better :P

pinkiebell · 2018-08-24T21:32:54Z

@thelostone-mc
Did you mean the button on the bounty details page or on the bounty change page?
Instead of 'Details'- at the top?

thelostone-mc · 2018-08-24T22:11:13Z

@pinkiebell the button on the bounty details page

And fix one status code.

pinkiebell · 2018-08-24T22:18:26Z

@thelostone-mc Done 👍

thelostone-mc · 2018-08-24T22:18:35Z

sweet!! will merge this in once @PixelantDesign reviews it 👍

PixelantDesign

Looking good @pinkiebell!

On the buttons, could we change....

'Change Bounty Details' ----> 'Edit Issue Details'
Change Details Screen...could we change the commit button to "Update Issue Details"

Nice work!

PixelantDesign · 2018-08-25T01:40:46Z

My other question is, if a funder is updating the issue details..should the following also happen...

Gitcoin Bot should update the thread with the revised details.
The funder should receive a confirmation email of the change.
Anyone that has Started Work on the issue should also receive an email confirmation.

Thoughts from the group? @owocki @vs77bb @thelostone-mc @pinkiebell.

pinkiebell · 2018-08-25T06:00:02Z

@PixelantDesign
Copy update done!
Regarding your questions, 2. and 3. are already the case with this PR.
For number 1. any ideas how that should look like?

vs77bb · 2018-08-27T01:39:07Z

LGTM!

Gitcoin Bot should update the thread with the revised details.

I think we should hold off on this for now. There's already enough comments on the Github thread, IMO. If it turns out to be an issue, we could include 'Approval' vs. 'Permissions' bounties in a v2 of the PR @oogetyboogety is working on regarding the Gitcoin Bot copy updates!

PixelantDesign · 2018-08-27T13:46:03Z

sounds good. Let's merge @thelostone-mc @SaptakS ?

Addressed

thelostone-mc · 2018-08-27T18:15:07Z

@pinkiebell thanks for the contribution ^_^

vs77bb · 2018-08-28T14:00:48Z

Sweeeeeeeeeetttt!

stickler-ci reviewed Aug 8, 2018

View reviewed changes

pinkiebell mentioned this pull request Aug 8, 2018

UX Add Project Type + Approval Settings to Issue Details #1928

Closed

8 tasks

owocki reviewed Aug 20, 2018

View reviewed changes

stickler-ci reviewed Aug 21, 2018

View reviewed changes

pinkiebell changed the title ~~WIP: Change Bounty Details~~ Change Bounty Details Aug 21, 2018

owocki previously approved these changes Aug 22, 2018

View reviewed changes

Change Bounty Details

a4f95b8

bounty details ('experience_level', 'project_length', 'bounty_type', 'permission_type', 'project_type') can be changed if the bounty is still on 'the happy path' by the funder or staff. Fixes #1928

pinkiebell dismissed owocki’s stale review via a4f95b8 August 24, 2018 10:51

thelostone-mc previously approved these changes Aug 24, 2018

View reviewed changes

thelostone-mc requested review from vs77bb and PixelantDesign August 24, 2018 21:04

thelostone-mc added the enhancement This is a feature to be enhanced or improved. label Aug 24, 2018

Update your Bounty Settings to get the right Crowd

18dc934

And fix one status code.

pinkiebell dismissed thelostone-mc’s stale review via 18dc934 August 24, 2018 22:17

PixelantDesign previously requested changes Aug 25, 2018

View reviewed changes

Change Bounty Details: copy update

537ac16

thelostone-mc approved these changes Aug 27, 2018

View reviewed changes

thelostone-mc merged commit 2f65f25 into gitcoinco:master Aug 27, 2018

pinkiebell deleted the bounty_changed branch November 6, 2018 08:41

		@@ -0,0 +1,72 @@

		// Overwrite from shared.js
		function trigger_form_hooks() {

Change Bounty Details #1968

Change Bounty Details #1968

Conversation

pinkiebell commented Aug 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 8, 2018 • edited Loading

Codecov Report

pinkiebell commented Aug 16, 2018

owocki commented Aug 17, 2018

pinkiebell commented Aug 17, 2018

owocki commented Aug 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pinkiebell commented Aug 21, 2018 • edited Loading

Choose a reason for hiding this comment

pinkiebell commented Aug 21, 2018

owocki commented Aug 22, 2018

thelostone-mc commented Aug 24, 2018

pinkiebell commented Aug 24, 2018

thelostone-mc left a comment

Choose a reason for hiding this comment

thelostone-mc commented Aug 24, 2018

pinkiebell commented Aug 24, 2018

thelostone-mc commented Aug 24, 2018

pinkiebell commented Aug 24, 2018

thelostone-mc commented Aug 24, 2018 • edited Loading

PixelantDesign left a comment

Choose a reason for hiding this comment

PixelantDesign commented Aug 25, 2018

pinkiebell commented Aug 25, 2018

vs77bb commented Aug 27, 2018

PixelantDesign commented Aug 27, 2018

thelostone-mc commented Aug 27, 2018

vs77bb commented Aug 28, 2018

pinkiebell commented Aug 8, 2018 •

edited

Loading

codecov bot commented Aug 8, 2018 •

edited

Loading

pinkiebell commented Aug 21, 2018 •

edited

Loading

thelostone-mc commented Aug 24, 2018 •

edited

Loading