Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FullStory #2009

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Remove FullStory #2009

merged 1 commit into from
Aug 15, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Aug 15, 2018

Description

The goal of this PR is to eliminate the fetching/usage of the FullStory JS library since we're actively using Hotjar.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

analytics, fullstory

Testing

Locally

@mbeacom mbeacom added the frontend This needs frontend expertise. label Aug 15, 2018
@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #2009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2009   +/-   ##
=======================================
  Coverage   25.36%   25.36%           
=======================================
  Files         132      132           
  Lines       10891    10891           
  Branches     1456     1456           
=======================================
  Hits         2763     2763           
  Misses       8052     8052           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b93d3...3665a88. Read the comment docs.

@SaptakS SaptakS merged commit dad30cf into master Aug 15, 2018
@mbeacom mbeacom deleted the remove-fullstory branch August 15, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants