Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix widget errors #2064

Merged
merged 5 commits into from
Aug 22, 2018
Merged

fix widget errors #2064

merged 5 commits into from
Aug 22, 2018

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Aug 22, 2018

Description

Fix filtering by org
Fix urls of bounties

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Fixes: #2063

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #2064 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   27.95%   27.95%           
=======================================
  Files         133      133           
  Lines       10913    10913           
  Branches     1463     1463           
=======================================
  Hits         3051     3051           
  Misses       7753     7753           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14268ac...a5087a3. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, lgtm. Just the one question about the update that exists in master already.

@@ -296,7 +296,7 @@

CACHES = {
'default': env.cache(),
COLLECTFAST_CACHE: env.cache('COLLECTFAST_CACHE_URL'),
COLLECTFAST_CACHE: env.cache('COLLECTFAST_CACHE_URL', default='dbcache://collectfast'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in here, should it? 🤔 This is in master already.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - :shipit: 🚢

@mbeacom mbeacom merged commit f8e39e2 into gitcoinco:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget errors
2 participants