Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base elastic apm integration #2092

Merged
merged 3 commits into from
Aug 24, 2018
Merged

Add base elastic apm integration #2092

merged 3 commits into from
Aug 24, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Aug 24, 2018

Description

The goal of this PR is to introduce the elastic apm integration for python/django.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

apm, performance, logging

Testing

Locally

Refers/Fixes

Ref #1873 #1208 #1207

Screenshots

screenshot 2018-08-24 13 42 08

screenshot 2018-08-24 13 43 00

screenshot 2018-08-24 13 43 25

screenshot 2018-08-24 13 44 55

@mbeacom mbeacom added backend This needs backend expertise. performance labels Aug 24, 2018
@mbeacom mbeacom added this to the August 2018 milestone Aug 24, 2018
@mbeacom mbeacom self-assigned this Aug 24, 2018
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #2092 into master will increase coverage by 0.01%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
+ Coverage   28.11%   28.12%   +0.01%     
==========================================
  Files         136      136              
  Lines       11033    11110      +77     
  Branches     1477     1485       +8     
==========================================
+ Hits         3102     3125      +23     
- Misses       7822     7874      +52     
- Partials      109      111       +2
Impacted Files Coverage Δ
app/app/settings.py 78.57% <7.14%> (-4.77%) ⬇️
app/retail/emails.py 22.56% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf11eaf...35ac9a9. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAYAYAYAY

@mbeacom mbeacom merged commit 1a5e602 into master Aug 24, 2018
@mbeacom mbeacom deleted the elastic-apm branch August 24, 2018 18:53
lastmjs pushed a commit to lastmjs/web that referenced this pull request Aug 25, 2018
* Add base elastic apm integration

* Handle debug env for stage

* Adjust logging for elastic
vlad2689 pushed a commit to vlad2689/web that referenced this pull request Aug 27, 2018
* Add base elastic apm integration

* Handle debug env for stage

* Adjust logging for elastic
vlad2689 pushed a commit to vlad2689/web that referenced this pull request Sep 15, 2018
* Add base elastic apm integration

* Handle debug env for stage

* Adjust logging for elastic
vlad2689 pushed a commit to vlad2689/web that referenced this pull request Sep 15, 2018
* Add base elastic apm integration

* Handle debug env for stage

* Adjust logging for elastic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants