Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrates from current_bounty=True to .current() because the latter is more exhaustive #2105

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Aug 27, 2018

migrates from current_bounty=True to .current() because the latter is more exhaustive

@@ -65,7 +63,7 @@ def handle(self, *args, **options):
fulfiller_email = accepted_fulfillment.fulfiller_email
is_fulfiller_and_funder_same_person = (fulfiller_email == submitter_email)
fulfillment_pks = BountyFulfillment.objects.filter(accepted=True, fulfiller_email=fulfiller_email).values_list('pk', flat=True)
previous_bounties = Bounty.objects.filter(web3_created__lt=bounty.web3_created, idx_status__in=statues, fulfillments__pk__in=fulfillment_pks, current_bounty=True).exclude(pk=bounty.pk).distinct()
previous_bounties = Bounty.objects.current().filter(web3_created__lt=bounty.web3_created, idx_status__in=statues, fulfillments__pk__in=fulfillment_pks).exclude(pk=bounty.pk).distinct()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (200 > 120 characters)

@owocki owocki merged commit 7f05f24 into master Aug 27, 2018
@mbeacom mbeacom deleted the kevin/current_bounty_refactor branch September 5, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants