small tip tweaks #2111
Merged
small tip tweaks #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
owocki
commented
Aug 28, 2018
owocki
commented
- stores user agent
- makes searchable by ip and metadata
stickler-ci
reviewed
Aug 28, 2018
app/dashboard/admin.py
Outdated
| @@ -77,7 +77,7 @@ class TipAdmin(admin.ModelAdmin): | |||
| raw_id_fields = ['recipient_profile', 'sender_profile'] | |||
| ordering = ['-id'] | |||
| readonly_fields = ['resend', 'claim'] | |||
| search_fields = ['tokenName', 'comments_public', 'comments_priv', 'from_name', 'username', 'network', 'github_url', 'url', 'emails', 'from_address', 'receive_address'] | |||
| search_fields = ['tokenName', 'comments_public', 'comments_priv', 'from_name', 'username', 'network', 'github_url', 'url', 'emails', 'from_address', 'receive_address', 'ip', 'metadata'] | |||
There was a problem hiding this comment.
E501 line too long (189 > 120 characters)
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
==========================================
- Coverage 27.91% 27.91% -0.01%
==========================================
Files 136 136
Lines 11130 11132 +2
Branches 1499 1499
==========================================
Hits 3107 3107
- Misses 7913 7915 +2
Partials 110 110
Continue to review full report at Codecov.
|
mbeacom
previously approved these changes
Aug 28, 2018
app/dashboard/tip_views.py
Outdated
| @@ -290,6 +290,10 @@ def send_tip_3(request): | |||
| to_emails = list(set(to_emails)) | |||
| expires_date = timezone.now() + timezone.timedelta(seconds=params['expires_date']) | |||
|
|
|||
| # metadata | |||
| metadata = params['metadata'] | |||
| metadata['user_agent'] = request.META['HTTP_USER_AGENT'] | |||
There was a problem hiding this comment.
🤔 - HTTP_USER_AGENT should always be present in the META. This shouldn't be a problem.
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.