Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update : how_it_works page #2121

Merged
merged 2 commits into from
Aug 30, 2018
Merged

update : how_it_works page #2121

merged 2 commits into from
Aug 30, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 29, 2018 •
edited
Loading

Description
  • restructures the templates
  • updated funder / contributor sections
  • replaced image with compressed svg
  • ensured all text is wrapped within trans
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • how it works
Testing

x

Fixes

@thelostone-mc thelostone-mc self-assigned this Aug 29, 2018
@thelostone-mc thelostone-mc added the frontend This needs frontend expertise. label Aug 29, 2018
@thelostone-mc thelostone-mc force-pushed the feature/how-it-works branch 5 times, most recently from 50aef82 to a17b885 Compare August 30, 2018 15:02
@codecov
Copy link

codecov bot commented Aug 30, 2018 •
edited
Loading

Codecov Report

Merging #2121 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   27.87%   27.87%           
=======================================
  Files         136      136           
  Lines       11148    11148           
  Branches     1502     1502           
=======================================
  Hits         3108     3108           
  Misses       7930     7930           
  Partials      110      110
Impacted Files Coverage Δ
app/retail/views.py 32.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f69db7...32e96cf. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the feature/how-it-works branch 3 times, most recently from 850d746 to 34ead23 Compare August 30, 2018 16:26
@thelostone-mc thelostone-mc changed the title TODO update : how_it_works page update : how_it_works page Aug 30, 2018
@thelostone-mc
rebirth: how it works
32e96cf 
- replaced img with svg
- updated flow for funder + contributor as per design
@thelostone-mc thelostone-mc mentioned this pull request Aug 30, 2018
Closed
3 tasks
@PixelantDesign
Copy link
Contributor

Lookin great!!!!!

SaptakS
SaptakS approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 917e74f into gitcoinco:master Aug 30, 2018
@thelostone-mc thelostone-mc deleted the feature/how-it-works branch August 30, 2018 18:47
@thelostone-mc thelostone-mc mentioned this pull request Aug 30, 2018
Closed
16 tasks
@owocki owocki mentioned this pull request Sep 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptakS SaptakS SaptakS approved these changes

Assignees

@thelostone-mc thelostone-mc

Labels
frontend This needs frontend expertise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thelostone-mc @PixelantDesign @SaptakS @mbeacom