Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty: changes cancel button to red #2146

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Sep 3, 2018

PR does three things

  • bounty details page -> updates cancel button color to red
  • update banner & cancel button color to red
  • prettifies admin control

screen shot 2018-09-03 at 7 50 12 pm

screencapture-localhost-8000-issue-cancel-2018-09-04-16_22_29

x

Fixes: #2145

@thelostone-mc thelostone-mc added the frontend This needs frontend expertise. label Sep 3, 2018
@thelostone-mc thelostone-mc self-assigned this Sep 3, 2018
@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #2146 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   27.83%   27.82%   -0.01%     
==========================================
  Files         136      136              
  Lines       11167    11169       +2     
  Branches     1509     1509              
==========================================
  Hits         3108     3108              
- Misses       7949     7951       +2     
  Partials      110      110
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 49.37% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26875a5...0d69a29. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Sep 4, 2018

is it worth changing the color of the button on the bounty/kill page itself, too?

@thelostone-mc
Copy link
Member Author

@owocki ah nice catch ! Added that and attached a screenshot

@SaptakS SaptakS merged commit d3addf5 into gitcoinco:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants