Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: prettified /help page #337

Merged
merged 2 commits into from
Feb 1, 2018
Merged

css: prettified /help page #337

merged 2 commits into from
Feb 1, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 31, 2018

Description
  • optimized for mobile
  • gave breathing space for FAQ and added basic animation (not visible in the gif )
  • changed fonts to OpenSans
  • refactored skeleton

help

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
Refers/Fixes

@@ -0,0 +1,79 @@
body {
font-family: "OpenSans";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to consolidate either around Futura or OpenSans... cc @PixelantDesign

Copy link
Member Author

@thelostone-mc thelostone-mc Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer why the change is being made : #133 (comment)

I couldn't find the conversation which algae12 refers on slack ( as free versions lets you search only the latest history 😓 )

@PixelantDesign
Copy link
Contributor

Hello! I think we should stick with Futura for the time being. Would it be possible to set the tracking to zero and add hover states #3E00FF to the topics on the help site?

- optimized for mobile
- gave breathing space for FAQ
- changed fonts to OpenSans
- refactored skeleton
@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files          87       87           
  Lines        4124     4124           
  Branches      493      493           
=======================================
  Hits          974      974           
  Misses       3142     3142           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50b937...c975838. Read the comment docs.

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Feb 1, 2018

@owocki Bugged @PixelantDesign offline and got things changed. review + merge before I have to resolve more conflicts ? Please 😝

the on hover is also added! ^_^

screenshot-2018-1-31 gitcoin push open source repos forward

@owocki
Copy link
Contributor

owocki commented Feb 1, 2018

lgtm; @mbeacom ?

@@ -22,21 +22,21 @@
<head>
{% include 'shared/head.html' %}
{% include 'shared/cards.html' %}
<link rel="stylesheet" href="/static/v2/css/help.css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update this to <link rel="stylesheet" href="{% static "v2/css/help.css" %}">

{% endfor %}
</ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation for this block?

- replaced OpenSans with Futura
- fixed indentation
@thelostone-mc
Copy link
Member Author

@mbeacom Done!

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit: Thanks @thelostone-mc !

@owocki owocki merged commit 5c7b833 into gitcoinco:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants