-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css: prettified /help page #337
Conversation
app/assets/v2/css/help.css
Outdated
@@ -0,0 +1,79 @@ | |||
body { | |||
font-family: "OpenSans"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to consolidate either around Futura or OpenSans... cc @PixelantDesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refer why the change is being made : #133 (comment)
I couldn't find the conversation which algae12 refers on slack ( as free versions lets you search only the latest history 😓 )
Hello! I think we should stick with Futura for the time being. Would it be possible to set the tracking to zero and add hover states #3E00FF to the topics on the help site? |
- optimized for mobile - gave breathing space for FAQ - changed fonts to OpenSans - refactored skeleton
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 23.61% 23.61%
=======================================
Files 87 87
Lines 4124 4124
Branches 493 493
=======================================
Hits 974 974
Misses 3142 3142
Partials 8 8 Continue to review full report at Codecov.
|
@owocki Bugged @PixelantDesign offline and got things changed. review + merge before I have to resolve more conflicts ? Please 😝 the on hover is also added! ^_^ |
lgtm; @mbeacom ? |
app/retail/templates/help.html
Outdated
@@ -22,21 +22,21 @@ | |||
<head> | |||
{% include 'shared/head.html' %} | |||
{% include 'shared/cards.html' %} | |||
<link rel="stylesheet" href="/static/v2/css/help.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to update this to <link rel="stylesheet" href="{% static "v2/css/help.css" %}">
app/retail/templates/help.html
Outdated
{% endfor %} | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the indentation for this block?
- replaced OpenSans with Futura - fixed indentation
@mbeacom Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm Thanks @thelostone-mc !
Description
Checklist
Affected core subsystem(s)
Refers/Fixes