cleaner funded issue urls #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i could migrate all of the kill/submit/accept functionality.. but figured thatll be easier to do once #406 is done |
mbeacom
added
enhancement
|
@mbeacom just resolved merge conflicts and isort issues.. can i get an 👀 ? |
mbeacom
approved these changes
Mar 6, 2018
app/assets/v2/js/pages/dashboard.js
Outdated
| @@ -187,11 +187,7 @@ var refreshBounties = function(){ | |||
| } else if(result['fulfiller_address'] != '0x0000000000000000000000000000000000000000'){ | |||
| result['my_bounty'] = '<a class="btn font-smaller-2 btn-sm btn-outline-dark" role="button" href="#">'+result['status']+'</span></a>'; | |||
| } | |||
| if (result['web3_type'] == 'legacy_gitcoin') { | |||
| result.action = '/legacy/funding/details?url=' + result.github_url; | |||
There was a problem hiding this comment.
Will this 💥 legacy bounty rendering?
There was a problem hiding this comment.
just put in a fix for htis
mbeacom
reviewed
Mar 6, 2018
There was a problem hiding this comment.
Tests appear to be failing:
4 failed
- app/dashboard/views.py:? isort-check
- app/dashboard/tests/test_dashboard_models.py:41 DashboardModelsTest.test_bounty
- app/dashboard/tests/test_notifications.py:66 DashboardNotificationsTestCase.test_build_github_notification_killed_bounty
- app/dashboard/tests/test_notifications.py:58 DashboardNotificationsTestCase.test_build_github_notification_new_bounty
|
2701111 fixes the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before: https://gitcoin.co/funding/details?url=https://github.com/gitcoinco/web/issues/450
after: https://gitcoin.co/issue/gitcoinco/web/450
backwards compatible: ✅