Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaner funded issue urls #452

Merged
merged 10 commits into from
Mar 7, 2018
Merged

cleaner funded issue urls #452

merged 10 commits into from
Mar 7, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Feb 15, 2018

@owocki
Copy link
Contributor Author

owocki commented Feb 15, 2018

i could migrate all of the kill/submit/accept functionality.. but figured thatll be easier to do once #406 is done

@mbeacom mbeacom added enhancement This is a feature to be enhanced or improved. backend This needs backend expertise. labels Mar 2, 2018
@owocki
Copy link
Contributor Author

owocki commented Mar 6, 2018

@mbeacom just resolved merge conflicts and isort issues.. can i get an 👀 ?

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the legacy bounty comment, lgtm.

@@ -187,11 +187,7 @@ var refreshBounties = function(){
} else if(result['fulfiller_address'] != '0x0000000000000000000000000000000000000000'){
result['my_bounty'] = '<a class="btn font-smaller-2 btn-sm btn-outline-dark" role="button" href="#">'+result['status']+'</span></a>';
}
if (result['web3_type'] == 'legacy_gitcoin') {
result.action = '/legacy/funding/details?url=' + result.github_url;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this 💥 legacy bounty rendering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just put in a fix for htis

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests appear to be failing:

       4 failed
         - app/dashboard/views.py:? isort-check
         - app/dashboard/tests/test_dashboard_models.py:41 DashboardModelsTest.test_bounty
         - app/dashboard/tests/test_notifications.py:66 DashboardNotificationsTestCase.test_build_github_notification_killed_bounty
         - app/dashboard/tests/test_notifications.py:58 DashboardNotificationsTestCase.test_build_github_notification_new_bounty

@owocki
Copy link
Contributor Author

owocki commented Mar 7, 2018

2701111 fixes the tests

@owocki owocki merged commit 791af06 into master Mar 7, 2018
@owocki owocki removed the in progress label Mar 7, 2018
@mbeacom mbeacom deleted the kevin/url-updates branch March 7, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. enhancement This is a feature to be enhanced or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants