Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort-check build failure #459

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

JakeStoeffler
Copy link
Contributor

Description

Fixes the currently failing build messages:

――――――――――――――――――――――――――――――――― isort-check ――――――――――――――――――――――――――――――――――
ERROR: /home/travis/build/gitcoinco/web/app/dashboard/views.py Imports are incorrectly sorted.
     Subscription, Tip,
 )
 from dashboard.notifications import maybe_market_tip_to_email, maybe_market_tip_to_github, maybe_market_tip_to_slack
+from dashboard.utils import get_bounty, getBountyID, has_tx_mined
 from dashboard.utils import process_bounty as web3_process_bounty
-from dashboard.utils import get_bounty, getBountyID, has_tx_mined
 from gas.utils import conf_time_spread, eth_usd_conv_rate, recommend_min_gas_price_to_confirm_in_time
 from github.utils import get_auth_url, get_github_emails, get_github_primary_email, is_github_token_valid
 from marketing.models import Keyword
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

@codecov
Copy link

codecov bot commented Feb 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2ff3281). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #459   +/-   ##
=========================================
  Coverage          ?   28.93%           
=========================================
  Files             ?       88           
  Lines             ?     4414           
  Branches          ?      541           
=========================================
  Hits              ?     1277           
  Misses            ?     3091           
  Partials          ?       46
Impacted Files Coverage Δ
app/dashboard/views.py 19.56% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff3281...2a61ba3. Read the comment docs.

@JakeStoeffler
Copy link
Contributor Author

Hey @owocki, @mbeacom this should be pretty safe to merge in and fix the failing master branch build.

@mbeacom mbeacom merged commit dc54efa into gitcoinco:master Feb 17, 2018
@mbeacom
Copy link
Contributor

mbeacom commented Feb 17, 2018

@JakeStoeffler Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants