-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: base setup #505
Conversation
i wish there was an easy way to say via github diffs that this is just formatting changes without having to do it line by line :/ this lgtm; @mbeacom ? |
@owocki I also added another commit here! |
@thelostone-mc -- I've added |
@eswarasai thoughts on shifting to 2 spaces = 1 tab for html pages ? |
@thelostone-mc -- Sure. If that's what ideal and preferable, then we can definitely remove |
defer to @mbeacom on this one.. ill do whatever the group does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I'm fine with the indentation change. I think it would be beneficial for us to document the styling guidelines, though.
Is it in the roadmap to use something like Prettier to codify code formatting? |
@mkosowsk Yes! We're currently in the deliberation stage of determining an approach to automatic styling and enforcement of style. I'd love to remove the guess work as much as possible for community contributors and reduce the friction (as well as manual interaction/intervention) for contributions. I'm open to discuss how we tackle this moving forward. |
@mbeacom Using Prettier seems relatively straightforward:
Might be interesting to open up to the community what type of standards they think are good to enforce 👍🏻 Think this is a very important topic to tackle so that contributors can focus their energy on more crucial things, like whether or not to use emoji in the codebase. I personally give that idea two 👍 way up! |
Description
Reason for this PR
Rather than working on explorer page and submitting a PR with tons of changes.
I'd wanna break it into batches (small deliverables ) => easier to review and merge
This PR has two commits
Muli
font family/explorer
page and added missing closing tagThis would be the first of the series.
Me and @eswarasai will start on the explorer page soon. Figured I'd get some cleaning up done beforehand to make our work easier
Checklist
Refers/Fixes
cc: @owocki