Add django auth framework #574

mbeacom · 2018-03-08T16:20:16Z

Description

The goal of this PR is to enable the Django authentication and user framework, refactoring our current auth flow to use User handling with GH, and remove custom Github middleware / views.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

Auth, Sessions

Testing

This will need tested on staging before being merged live.

Refers/Fixes

Fixes: #312
Refs: #234

codecov · 2018-03-08T17:35:27Z

Codecov Report

Merging #574 into master will increase coverage by 0.37%.
The diff coverage is 44.7%.

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   33.99%   34.36%   +0.37%     
==========================================
  Files         101       99       -2     
  Lines        5775     5735      -40     
  Branches      672      664       -8     
==========================================
+ Hits         1963     1971       +8     
+ Misses       3733     3685      -48     
  Partials       79       79

Impacted Files	Coverage Δ
app/app/context.py	`0% <0%> (ø)`	⬆️
app/github/utils.py	`75.59% <0%> (-3.58%)`	⬇️
app/app/pipeline.py	`0% <0%> (ø)`
app/app/urls.py	`93.54% <100%> (+0.21%)`	⬆️
app/app/settings.py	`81.37% <100%> (+1.37%)`	⬆️
app/dashboard/views.py	`18.67% <26.08%> (+1.02%)`	⬆️
app/dashboard/models.py	`68.38% <50%> (-0.87%)`	⬇️
app/marketing/views.py	`11.2% <50%> (+0.36%)`	⬆️
app/app/utils.py	`20.15% <53.33%> (+3.77%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6db81c...aebc01b. Read the comment docs.

mbeacom · 2018-03-08T17:43:43Z

Ouch. Authentication checks without tested views kills coverage! Adding some view tests in this PR to resolve the coverage issues.

owocki

have not tested but code LGTM. mind posting a little bit about how you regression tested this?

owocki · 2018-03-08T23:31:14Z

app/app/urls.py

    # Interests
    path('actions/bounty/<int:bounty_id>/interest/new/', dashboard.views.new_interest, name='express-interest'),
    path('actions/bounty/<int:bounty_id>/interest/remove/', dashboard.views.remove_interest, name='remove-interest'),
    path('actions/bounty/<int:bounty_id>/interest/', dashboard.views.interested_profiles, name='interested-profiles'),
    # Legacy Support
    path('legacy/', include('legacy.urls', namespace='legacy')),
+    re_path(r'^logout/$', auth_views.logout, name='logout'),


we may have to modify some of the cloudfront settings associated with this

owocki · 2018-03-08T23:35:10Z

app/dashboard/views.py

@@ -518,7 +537,7 @@ def bounty_details(request, ghuser='', ghrepo='', ghissue=0):
                params['is_legacy'] = bounty.is_legacy  # TODO: Remove this following legacy contract sunset.
                if profile_id:
                    profile_ids = list(params['interested_profiles'].values_list('profile_id', flat=True))
-                    params['profile_interested'] = request.session.get('profile_id') in profile_ids
+                    params['profile_interested'] = profile_id in profile_ids


strangely enough it doesnt seem like profile_interested is even being used at all in the template

Yeah, I noticed that but opted to not yank it out yet. I can remove it here though.

owocki · 2018-03-09T16:36:35Z

added a new link to the django github url route in #541 -- will need to make sure that is migrated in this PR!

mbeacom · 2018-03-09T18:19:50Z

@owocki Faucet GH URL reverse updated.

jasonrhaas

Overall the Python looks good! So does the @login_required mean that people need to have accounts now? Or is it still using the github account?

jasonrhaas · 2018-03-09T18:28:14Z

app/dashboard/views.py

@@ -538,7 +544,21 @@ def bounty_details(request, ghuser='', ghrepo='', ghissue=0):


 def profile_helper(handle):
-    """Define the profile helper."""
+    """Define the profile helper.


Docstrings 👌

jasonrhaas · 2018-03-09T18:32:47Z

Is there any additional testing that needs to be done? I looked at the code but hard to get a feel for the new changes without running it through the bounty process.

mkosowsk · 2018-04-05T21:40:53Z

Will check for breadth tonight, will check for depth and test on the weekend :)

thelostone-mc

LGTM

PS: the naming convention fixes :D
#impressed

mkosowsk · 2018-04-06T10:37:44Z

app/dashboard/views.py

+        bounty = Bounty.objects.get(pk=bounty_id)
+    except Bounty.DoesNotExist:
+        return JsonResponse({'errors': ['Bounty doesn\'t exist!']},
+                            status=401)


Minor thing but if bounty doesn't exist this should be a 404, right?

Googled it up and came across this
Makes sense @mkosowsk !

Not sure where/why this showed up here, but I didn't add that xD It was from existing code that changed lines. Agreed, though!

@mbeacom sure we believe you :P

@thelostone-mc 😛 https://github.com/gitcoinco/web/blob/master/app/dashboard/views.py#L199

@thelostone-mc hmm you believe this or not? Not sure if I'm convinced 😂🤣

mkosowsk · 2018-04-06T10:38:24Z

app/dashboard/views.py

+        return JsonResponse({
+            'errors': ['Party haven\'t expressed interest on this bounty.'],
+            'success': False},
+            status=401)


Same as above, 404 here?

mkosowsk · 2018-04-06T10:39:58Z

@mbeacom Also digging the naming convention 👍🏻raised very minor concerns over 401 vs 404 in a couple spots but otherwise LGTM :)

mkosowsk · 2018-04-06T15:07:49Z

@mbeacom This guy just go live on production? 😍

Just a brainstorming question on DashboardTokensTest section... @thelostone-mc do you think we hit everything we needed to hit as far as assertions go for this?

This reverts commit cb64fd0, reversing changes made to e6db81c.

thelostone-mc · 2018-04-06T16:55:44Z

@mkosowsk It's on stage, tested it out
works fine ^_^

mbeacom added 2 commits March 8, 2018 10:50

Ref #312 - Add onetoone from profile to user and update session logic

e5b41dd

Remove gh middleware and views

7e9101b

mbeacom added needs-testing backend This needs backend expertise. labels Mar 8, 2018

mbeacom self-assigned this Mar 8, 2018

mbeacom added the in progress label Mar 8, 2018

mbeacom referenced this pull request Mar 8, 2018

gitcoin now knows about slack presence of its users

20fc422

Merge branch 'master' into mark-django-auth-int

0d9b73c

owocki reviewed Mar 8, 2018

View reviewed changes

mbeacom added 2 commits March 9, 2018 10:12

Remove unused import and some tests

45843e8

Remove profile_interested

f42efef

mbeacom added 2 commits March 9, 2018 11:38

Merge branch 'master' into mark-django-auth-int

3b36880

Merge branch 'master' into mark-django-auth-int

bcbdf14

jasonrhaas self-requested a review March 9, 2018 18:09

mbeacom added 2 commits March 9, 2018 13:12

Update faucet templates to use new GH auth

a8000c1

Update github utils

c5da429

jasonrhaas reviewed Mar 9, 2018

View reviewed changes

mbeacom added 4 commits March 9, 2018 13:44

Merge branch 'master' into mark-django-auth-int

d396f07

Merge branch 'master' into mark-django-auth-int

b271e04

Merge branch 'master' into mark-django-auth-int

1b2a804

Merge branch 'master' into mark-django-auth-int

09ef05b

mbeacom removed the wip label Apr 2, 2018

mbeacom changed the title ~~WIP: Add django auth framework~~ Add django auth framework Apr 2, 2018

mbeacom added 6 commits April 2, 2018 15:56

Merge branch 'master' into mark-django-auth-int

33ecd5a

Fix migrations

a0bb629

Merge branch 'master' into mark-django-auth-int

6c86c64

Merge branch 'master' into mark-django-auth-int

d521145

Make use of pipeline instead of using a signal

0835202

Minor token and funder check change

58d19c1

mbeacom mentioned this pull request Apr 5, 2018

Use Profile Email across everywhere #603

Closed

mbeacom added 6 commits April 5, 2018 11:07

Update pre and post login events to track location

f410436

Merge branch 'master' into mark-django-auth-int

704afdf

Fix url

7df67e3

Scrub session data during migration, crontab cleanup expired sessions

daa1e9b

Update migration

2732e2a

Fix migration derpness

b113dca

thelostone-mc approved these changes Apr 6, 2018

View reviewed changes

mkosowsk reviewed Apr 6, 2018

View reviewed changes

Merge branch 'master' into mark-django-auth-int

aebc01b

mbeacom merged commit cb64fd0 into gitcoinco:master Apr 6, 2018

mbeacom deleted the mark-django-auth-int branch April 6, 2018 15:06

mbeacom removed in progress labels Apr 6, 2018

mbeacom restored the mark-django-auth-int branch April 6, 2018 15:18

mbeacom added a commit that referenced this pull request Apr 6, 2018

Revert "Merge pull request #574 from mbeacom/mark-django-auth-int"

5633ae7

This reverts commit cb64fd0, reversing changes made to e6db81c.

mbeacom deleted the mark-django-auth-int branch April 6, 2018 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add django auth framework #574

Add django auth framework #574

mbeacom commented Mar 8, 2018

codecov bot commented Mar 8, 2018 •

edited

Loading

mbeacom commented Mar 8, 2018

owocki left a comment

owocki Mar 8, 2018

owocki Mar 8, 2018

mbeacom Mar 8, 2018

owocki Mar 8, 2018

owocki commented Mar 9, 2018

mbeacom commented Mar 9, 2018

jasonrhaas left a comment

jasonrhaas Mar 9, 2018

jasonrhaas commented Mar 9, 2018

mkosowsk commented Apr 5, 2018

thelostone-mc left a comment

mkosowsk Apr 6, 2018

thelostone-mc Apr 6, 2018 •

edited

Loading

mbeacom Apr 6, 2018

thelostone-mc Apr 6, 2018

mbeacom Apr 6, 2018

mkosowsk Apr 6, 2018

mkosowsk Apr 6, 2018

mkosowsk commented Apr 6, 2018

mkosowsk commented Apr 6, 2018

thelostone-mc commented Apr 6, 2018

Add django auth framework #574

Add django auth framework #574

Conversation

mbeacom commented Mar 8, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

codecov bot commented Mar 8, 2018 • edited Loading

Codecov Report

mbeacom commented Mar 8, 2018

owocki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Mar 9, 2018

mbeacom commented Mar 9, 2018

jasonrhaas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasonrhaas commented Mar 9, 2018

mkosowsk commented Apr 5, 2018

thelostone-mc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc Apr 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkosowsk commented Apr 6, 2018

mkosowsk commented Apr 6, 2018

thelostone-mc commented Apr 6, 2018

codecov bot commented Mar 8, 2018 •

edited

Loading

thelostone-mc Apr 6, 2018 •

edited

Loading