Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: added sort feature #578

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 8, 2018

Description

Added the sort feature in the search tab on the explorer page

help

  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
Refers

@thelostone-mc
Copy link
Member Author

@mbeacom would like this to be considered for merge post #573 if possible

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #578 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   28.56%   28.97%   +0.41%     
==========================================
  Files          89       93       +4     
  Lines        4695     4859     +164     
  Branches      561      569       +8     
==========================================
+ Hits         1341     1408      +67     
- Misses       3307     3404      +97     
  Partials       47       47
Impacted Files Coverage Δ
app/github/utils.py 83.43% <0%> (-1.53%) ⬇️
app/dashboard/views.py 18.59% <0%> (-0.41%) ⬇️
app/retail/emails.py 22.44% <0%> (-0.18%) ⬇️
app/marketing/models.py 85.18% <0%> (-0.15%) ⬇️
app/dashboard/models.py 68.38% <0%> (-0.02%) ⬇️
...eting/management/commands/assemble_leaderboards.py 0% <0%> (ø) ⬆️
app/app/urls.py 100% <0%> (ø) ⬆️
app/marketing/management/commands/sync_slack.py 0% <0%> (ø) ⬆️
app/app/context.py 0% <0%> (ø) ⬆️
app/faucet/models.py 88.23% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8407a6b...44eed33. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Mar 8, 2018

@thelostone-mc I'll be running through and testing both this and #573 shortly. Thanks for the contribution!

@mbeacom mbeacom self-requested a review March 8, 2018 19:35
@owocki
Copy link
Contributor

owocki commented Mar 9, 2018

just tested.. seems to work fine..

one thing thats missing that was in the old explorer... is the ability to sort by web3_created_on date.. i think that was a valuable way of sorting the data.. in fact i'd advocate for adding that in in such a way that it replaces either the 'difficulty' or 'length' sort options!

- updated the sort list
- fixed the dahhboard title alignment
@thelostone-mc
Copy link
Member Author

thelostone-mc commented Mar 9, 2018

@mbeacom @owocki Done 👍

I removed Difficulty + Length as those are already available in the left rails

help

@owocki
Copy link
Contributor

owocki commented Mar 9, 2018

LGTM; @mbeacom ?

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit 6ed63bc into gitcoinco:master Mar 9, 2018
@mbeacom mbeacom added frontend This needs frontend expertise. ui labels Mar 9, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.06 ETH (41.74 USD @ $695.6/ETH) has been granted to @thelostone-mc for this issue from Kevin. ⚡️

The sender had the following public comments:

Thx :)

Nice work @thelostone-mc! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@thelostone-mc thelostone-mc deleted the sort branch March 12, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants