General faucet cleanup #582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=========================================
Coverage ? 29.15%
=========================================
Files ? 93
Lines ? 4856
Branches ? 568
=========================================
Hits ? 1416
Misses ? 3393
Partials ? 47
Continue to review full report at Codecov.
|
|
@owocki When you have a moment, can I get 👀 on this? |
| 'user': user['items'][0] | ||
| } | ||
| response = {'status': 200, 'user': False} | ||
| if not len(user['items']) == 0 or not user['items'][0]['login'].lower() != profile.lower(): |
There was a problem hiding this comment.
this looks different than what was being done before?
There was a problem hiding this comment.
It is. I'm checking if not for both cases, defaulting to {'status': 200, 'user': False} and only updating response['user'] if the case is correct ^ - It's performing the same logic, just updating the one value if necessary to be more DRY.
| return JsonResponse({ | ||
| 'message': e.messages[0] | ||
| }, status=400) | ||
| github_profile = request.POST.get('githubProfile') |
There was a problem hiding this comment.
did not test here either.. can you do a runthrough of testing?
There was a problem hiding this comment.
It's doing the same exact thing, only catching in one place versus three since we're returning on exception anyway.
|
just left a few comments.. LGTM once its tested both success/fail cases |
|
@owocki The logic hasn't really changed. As for the python code, it's the same exact thing as before only a little more DRY. |
|
🚢 ed-- thanks! |
Description
The goal of this PR is to cleanup some of the logic and syntax associated with
Faucetand add docstrings.Checklist
Affected core subsystem(s)
faucet