fix for empty github notification #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
commented
Mar 14, 2018
| @@ -297,6 +297,9 @@ def build_profile_pairs(bounty): | |||
| """ | |||
| profile_handles = [] | |||
| for fulfillment in bounty.fulfillments.select_related('profile').all().order_by('pk'): | |||
| if fulfillment.profile and fulfillment.profile.handle and fulfillment.profile.absolute_url: | |||
| if fulfillment.profile and fulfillment.profile.handle.strip() and fulfillment.profile.absolute_url: | |||
There was a problem hiding this comment.
should make " " falsy
There was a problem hiding this comment.
the reason i did that is that this comment ( http://bits.owocki.com/0m450K2E0S3t/Screen%20Shot%202018-03-13%20at%206.01.19%20PM.png ) seems to have whitespace in it.. otherwise how did it pass the fulfillment.profile and fulfillment.profile.handle and fulfillment.profile.absolute_url check?
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 33.99% 33.97% -0.02%
==========================================
Files 92 92
Lines 5051 5053 +2
Branches 584 584
==========================================
Hits 1717 1717
- Misses 3267 3269 +2
Partials 67 67
Continue to review full report at Codecov.
|
mbeacom
reviewed
Mar 14, 2018
| @@ -297,6 +297,9 @@ def build_profile_pairs(bounty): | |||
| """ | |||
| profile_handles = [] | |||
| for fulfillment in bounty.fulfillments.select_related('profile').all().order_by('pk'): | |||
| if fulfillment.profile and fulfillment.profile.handle and fulfillment.profile.absolute_url: | |||
| if fulfillment.profile and fulfillment.profile.handle.strip() and fulfillment.profile.absolute_url: | |||
| profile_handles.append((fulfillment.profile.handle, fulfillment.profile.absolute_url)) | ||
| else: | ||
| addr = f"https://etherscan.io/address/{fulfillment.fulfiller_address}" | ||
| profile_handles.append((fulfillment.fulfiller_address, addr)) |
mbeacom
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for
http://bits.owocki.com/0m450K2E0S3t/Screen%20Shot%202018-03-13%20at%206.01.19%20PM.png
JoinColony/colonyNetwork#174 (comment)
Checklist
Affected core subsystem(s)
notifications
Testing
tested it